From: "Toke Høiland-Jørgensen" <toke@toke•dk>
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, cake@lists•bufferbloat.net
Subject: Re: [PATCH net-next v11 1/7] sched: Add Common Applications Kept Enhanced (cake) qdisc
Date: Wed, 16 May 2018 20:34:11 +0200 [thread overview]
Message-ID: <87vabnv49o.fsf@toke.dk> (raw)
In-Reply-To: <20180516.140203.2185491961233997679.davem@davemloft.net>
David Miller <davem@davemloft•net> writes:
> From: Toke Høiland-Jørgensen <toke@toke•dk>
> Date: Tue, 15 May 2018 17:12:44 +0200
>
>> +typedef u64 cobalt_time_t;
>> +typedef s64 cobalt_tdiff_t;
> ...
>> +static cobalt_time_t cobalt_get_time(void)
>> +{
>> + return ktime_get_ns();
>> +}
>> +
>> +static u32 cobalt_time_to_us(cobalt_time_t val)
>> +{
>> + do_div(val, NSEC_PER_USEC);
>> + return (u32)val;
>> +}
>
> If fundamentally you are working with ktime_t values, please use that type
> and the associated helpers.
>
> This is a valid argument that using custom typedefs provide documentation
> and an aid to understanding, but I think it doesn't serve that purpose
> very well here.
>
> So please just use ktime_t throughout instead of this cobalt_time_t
> and cobalt_tdiff_t. And then use helpers like ktime_to_us() which
> properly optimize for 64-bit vs. 32-bit hosts.
Can do :)
-Toke
next prev parent reply other threads:[~2018-05-16 18:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 15:12 [PATCH net-next v11 0/7] sched: Add Common Applications Kept Enhanced (cake) qdisc Toke Høiland-Jørgensen
2018-05-15 15:12 ` [PATCH net-next v11 1/7] " Toke Høiland-Jørgensen
2018-05-16 18:02 ` David Miller
2018-05-16 18:34 ` Toke Høiland-Jørgensen [this message]
2018-05-15 15:12 ` [PATCH net-next v11 5/7] sch_cake: Add DiffServ handling Toke Høiland-Jørgensen
2018-05-15 15:12 ` [PATCH net-next v11 7/7] sch_cake: Conditionally split GSO segments Toke Høiland-Jørgensen
2018-05-15 15:12 ` [PATCH net-next v11 3/7] sch_cake: Add optional ACK filter Toke Høiland-Jørgensen
2018-05-15 15:12 ` [PATCH net-next v11 6/7] sch_cake: Add overhead compensation support to the rate shaper Toke Høiland-Jørgensen
2018-05-15 15:12 ` [PATCH net-next v11 2/7] sch_cake: Add ingress mode Toke Høiland-Jørgensen
2018-05-15 15:12 ` [PATCH net-next v11 4/7] sch_cake: Add NAT awareness to packet classifier Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vabnv49o.fsf@toke.dk \
--to=toke@toke$(echo .)dk \
--cc=cake@lists$(echo .)bufferbloat.net \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox