From: Kalle Valo <kvalo@codeaurora•org>
To: Rajat Jain <rajatja@google•com>
Cc: Amitkumar Karwar <akarwar@marvell•com>,
Nishant Sarmukadam <nishants@marvell•com>,
linux-wireless@vger•kernel.org, netdev@vger•kernel.org,
Wei-Ning Huang <wnhuang@google•com>,
Brian Norris <briannorris@google•com>,
Eric Caruso <ejcaruso@chromium•org>,
Rajat Jain <rajatxjain@gmail•com>
Subject: Re: [v2] mwifiex: report wakeup for wowlan
Date: Tue, 04 Oct 2016 15:46:03 +0300 [thread overview]
Message-ID: <87vax8p9is.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CACK8Z6Fe34xdvd5-=3dNmqKXYC=Qr9+kpG46eCV7uFArLW+yyQ@mail.gmail.com> (Rajat Jain's message of "Mon, 3 Oct 2016 17:16:19 -0700")
Rajat Jain <rajatja@google•com> writes:
> Hello Kalie,
>
> On Mon, Oct 3, 2016 at 6:04 AM, Kalle Valo <kvalo@codeaurora•org> wrote:
>> Rajat Jain <rajatja@google•com> wrote:
>>> Enable notifying wakeup source to the PM core in case of
>>> a wake on wireless LAN event.
>>>
>>> Signed-off-by: Wei-Ning Huang <wnhuang@google•com>
>>> Signed-off-by: Rajat Jain <rajatja@google•com>
>>> Tested-by: Wei-Ning Huang <wnhuang@chromium•org>
>>> Reviewed-by: Eric Caruso <ejcaruso@chromium•org>
>>> Acked-by: Amitkumar Karwar <akarwar@marvell•com>
>>
>> The commit log doesn't give any background info. Does this fix a bug or
>> why is it needed?
>
> Some of chromeos' features (called "darkresume" in chromeos
> terminology) use and track the wake up sources using the wakeup
> attributes in sysfs. Since the wireless device can wake up the host,
> hence we wanted to add it as a wakeup source to the system, and in the
> case of an actual wakeup event, trigger to the PM core that it was
> indeed caused by the device and it increments the different counters
> etc. In the absence of this patch, the feature wasn't working very
> well (as it was apparently confused about the cause of wake up).
Thanks, makes sense. Please add that to the commit and send v3.
--
Kalle Valo
next prev parent reply other threads:[~2016-10-04 12:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 16:56 [PATCH] mwifiex: report wakeup for wowlan Rajat Jain
[not found] ` <1474995364-123069-1-git-send-email-rajatja-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-09-28 1:41 ` Rajat Jain
2016-09-28 1:45 ` [PATCH v2] " Rajat Jain
[not found] ` <1475027104-17423-1-git-send-email-rajatja-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-09-28 13:59 ` Amitkumar Karwar
2016-10-03 13:04 ` [v2] " Kalle Valo
[not found] ` <20161003130407.4D94161803@smtp.codeaurora.org>
[not found] ` <20161003130407.4D94161803-4h6buKAYkuurB/BPivuO70B+6BGkLq7r@public.gmane.org>
2016-10-04 0:16 ` Rajat Jain
2016-10-04 12:46 ` Kalle Valo [this message]
2016-10-04 20:37 ` [PATCH v3] " Rajat Jain
2016-11-17 6:41 ` [v3] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vax8p9is.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora$(echo .)org \
--cc=akarwar@marvell$(echo .)com \
--cc=briannorris@google$(echo .)com \
--cc=ejcaruso@chromium$(echo .)org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nishants@marvell$(echo .)com \
--cc=rajatja@google$(echo .)com \
--cc=rajatxjain@gmail$(echo .)com \
--cc=wnhuang@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox