public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Vivien Didelot <vivien.didelot@savoirfairelinux•com>
To: Guenter Roeck <linux@roeck-us•net>,
	Patrick Uiterwijk <patrick@puiterwijk•org>
Cc: davem@davemloft•net, linux@arm•linux.org.uk, andrew@lunn•ch,
	netdev@vger•kernel.org, Dennis Gilmore <dennis@ausil•us>,
	Peter Robinson <pbrobinson@gmail•com>
Subject: Re: [PATCH 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write}
Date: Sat, 26 Mar 2016 14:32:51 -0400	[thread overview]
Message-ID: <87vb49gkdo.fsf@ketchup.mtl.sfl> (raw)
In-Reply-To: <56F5F71B.3090703@roeck-us.net>

Hi Guenter,

Guenter Roeck <linux@roeck-us•net> writes:

>>> Is there some good reason for changing the name of those labels ?
>>
>> Vivien suggested to rename this since it makes more clear that this write is
>> meant to return to page 0 to make sure that phylib doesn't get confused
>> about the currently active page.
>>
>
> And "clear:" accomplishes that ? I would not have guessed.
> Wonder if anyone else does. I would have used a comment.
> 	/* Try to return to page 0 even after an error */
> or something like that.

"error" definitely doesn't make sense, especially in case of success. If
one has a better suggestion that "clear" for the label, I don't really
mind.

Thanks,
Vivien

next prev parent reply	other threads:[~2016-03-26 18:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-26  0:10 [PATCH 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write} Patrick Uiterwijk
2016-03-26  0:10 ` [PATCH 2/2] net: dsa: mv88e6xxx: Clear the PDOWN bit on setup Patrick Uiterwijk
2016-03-26 18:36   ` Vivien Didelot
2016-03-26  1:45 ` [PATCH 1/2] net: dsa: mv88e6xxx: Introduce _mv88e6xxx_phy_page_{read,write} Guenter Roeck
2016-03-26  1:58   ` Patrick Uiterwijk
2016-03-26  2:42     ` Guenter Roeck
2016-03-26 18:32       ` Vivien Didelot [this message]
2016-03-26 19:18         ` Andrew Lunn
2016-03-26 19:37           ` Vivien Didelot
2016-03-26 19:46             ` Andrew Lunn
2016-03-26 20:15               ` Vivien Didelot
2016-03-26 20:57         ` Guenter Roeck
2016-03-26 22:58           ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vb49gkdo.fsf@ketchup.mtl.sfl \
    --to=vivien.didelot@savoirfairelinux$(echo .)com \
    --cc=andrew@lunn$(echo .)ch \
    --cc=davem@davemloft$(echo .)net \
    --cc=dennis@ausil$(echo .)us \
    --cc=linux@arm$(echo .)linux.org.uk \
    --cc=linux@roeck-us$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=patrick@puiterwijk$(echo .)org \
    --cc=pbrobinson@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox