From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public•gmane.org>
To: Giel van Schijndel <me-sZ9Uef1cvPWHXe+LvDLADg@public•gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public•gmane.org,
Eliad Peller <eliad-Ix1uc/W3ht7QT0dZR+AlfA@public•gmane.org>,
"John W. Linville"
<linville-2XuSBdqkA4R54TAoqtyWWQ@public•gmane.org>,
Arik Nemtsov <arik-Ix1uc/W3ht7QT0dZR+AlfA@public•gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public•gmane.org (open
list:TI WILINK WIRELES...),
netdev-u79uwXL29TY76Z2rM5mHXA@public•gmane.org (open
list:NETWORKING DRIVERS)
Subject: Re: [PATCH RESEND 2/2] wlcore: align member-assigns in a structure-copy block
Date: Fri, 09 Jan 2015 19:03:45 +0200 [thread overview]
Message-ID: <87vbkfga32.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1420659525-22975-2-git-send-email-me-sZ9Uef1cvPWHXe+LvDLADg@public.gmane.org> (Giel van Schijndel's message of "Wed, 7 Jan 2015 20:38:38 +0100")
Giel van Schijndel <me-sZ9Uef1cvPWHXe+LvDLADg@public•gmane.org> writes:
> This highlights the differences (e.g. the bug fixed in the previous
> commit).
>
> Signed-off-by: Giel van Schijndel <me-sZ9Uef1cvPWHXe+LvDLADg@public•gmane.org>
> ---
> drivers/net/wireless/ti/wlcore/acx.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/wireless/ti/wlcore/acx.c b/drivers/net/wireless/ti/wlcore/acx.c
> index f28fa3b..93a2fa8 100644
> --- a/drivers/net/wireless/ti/wlcore/acx.c
> +++ b/drivers/net/wireless/ti/wlcore/acx.c
> @@ -1715,17 +1715,17 @@ int wl12xx_acx_config_hangover(struct wl1271 *wl)
> goto out;
> }
>
> - acx->recover_time = cpu_to_le32(conf->recover_time);
> - acx->hangover_period = conf->hangover_period;
> - acx->dynamic_mode = conf->dynamic_mode;
> - acx->early_termination_mode = conf->early_termination_mode;
> - acx->max_period = conf->max_period;
> - acx->min_period = conf->min_period;
> - acx->increase_delta = conf->increase_delta;
> - acx->decrease_delta = conf->decrease_delta;
> - acx->quiet_time = conf->quiet_time;
> - acx->increase_time = conf->increase_time;
> - acx->window_size = conf->window_size;
> + acx->recover_time = cpu_to_le32(conf->recover_time);
> + acx->hangover_period = conf->hangover_period;
> + acx->dynamic_mode = conf->dynamic_mode;
> + acx->early_termination_mode = conf->early_termination_mode;
> + acx->max_period = conf->max_period;
> + acx->min_period = conf->min_period;
> + acx->increase_delta = conf->increase_delta;
> + acx->decrease_delta = conf->decrease_delta;
> + acx->quiet_time = conf->quiet_time;
> + acx->increase_time = conf->increase_time;
> + acx->window_size = conf->window_size;
I would like to get an ACK from one of the wlcore developers if I should
apply this (or not).
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public•gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-09 17:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 18:00 [PATCH 1/2] Align member-assigns in a structure-copy block Giel van Schijndel
2015-01-04 18:00 ` [PATCH 2/2] Fix copy-paste bug: assign from src struct not dest Giel van Schijndel
2015-01-04 23:02 ` Giel van Schijndel
2015-01-05 9:54 ` Johannes Berg
2015-01-07 19:18 ` Giel van Schijndel
2015-01-07 22:16 ` Johannes Berg
2015-01-07 23:06 ` Arend van Spriel
2015-01-04 23:02 ` [PATCH 1/2] Align member-assigns in a structure-copy block Giel van Schijndel
2015-01-05 9:17 ` Kalle Valo
2015-01-05 9:16 ` Kalle Valo
[not found] ` <1420394427-19509-1-git-send-email-me-sZ9Uef1cvPWHXe+LvDLADg@public.gmane.org>
2015-01-07 18:40 ` Andy Shevchenko
2015-01-07 19:38 ` [PATCH RESEND 1/2] wlcore: fix copy-paste bug: assign from src struct not dest Giel van Schijndel
2015-01-07 19:38 ` [PATCH RESEND 2/2] wlcore: align member-assigns in a structure-copy block Giel van Schijndel
[not found] ` <1420659525-22975-2-git-send-email-me-sZ9Uef1cvPWHXe+LvDLADg@public.gmane.org>
2015-01-09 17:03 ` Kalle Valo [this message]
[not found] ` <87vbkfga32.fsf-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2015-01-11 10:22 ` Eliad Peller
2015-01-11 20:32 ` Giel van Schijndel
2015-01-15 13:23 ` Kalle Valo
2015-01-23 17:07 ` [RESEND, 1/2] wlcore: fix copy-paste bug: assign from src struct not dest Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbkfga32.fsf@kamboji.qca.qualcomm.com \
--to=kvalo-sgv2jx0feol9jmxxk+q4oq@public$(echo .)gmane.org \
--cc=arik-Ix1uc/W3ht7QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=eliad-Ix1uc/W3ht7QT0dZR+AlfA@public$(echo .)gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public$(echo .)gmane.org \
--cc=me-sZ9Uef1cvPWHXe+LvDLADg@public$(echo .)gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public$(echo .)gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox