From: Luis Henriques <luis.henriques@canonical•com>
To: Joe Jin <joe.jin@oracle•com>
Cc: Matt Carlson <mcarlson@broadcom•com>,
Xiao Jiang <jgq516@gmail•com>, Michael Chan <mchan@broadcom•com>,
Guru Anbalagane <guru.anbalagane@oracle•com>,
Gurudas Pai <gurudas.pai@oracle•com>,
"netdev\@vger.kernel.org" <netdev@vger•kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger•kernel.org>,
Greg Marsden <greg.marsden@oracle•com>,
Luis Henriques <luis.henriques@canonical•com>
Subject: Re: [PATCH] tg3: Dont dump registers if interface not ready.
Date: Thu, 22 Mar 2012 13:17:17 +0000 [thread overview]
Message-ID: <87vclw93mq.fsf@camandro.org> (raw)
In-Reply-To: <4E9BFAF2.3040703@oracle.com> (Joe Jin's message of "Mon, 17 Oct 2011 17:52:50 +0800")
Joe Jin <joe.jin@oracle•com> writes:
Hi,
> Hi Matt,
>
> Sorry for late response, after apply your changes, driver did not dumped
> registers info as well, but still hit tg3_stop_block timed out as below:
>
...
>
> Any suggestion?
I was wondering if there any progress with this patch. Is this
stalled, or has it been dropped?
Cheers,
--
Luis
>
> Thanks,
> Joe
>
> On 10/05/11 10:14, Matt Carlson wrote:
>> On Wed, Sep 28, 2011 at 11:50:01PM -0700, Xiao Jiang wrote:
>>> Joe Jin wrote:
>>>> When bootup the server with BCM5704 Gigabit Ethernet get below warning:
>>>>
>>>> tg3 0000:03:01.0: eth0: DMA Status error. Resetting chip.
>>>> <Registers state of device>
>>>> tg3 0000:03:01.0: eth0: 0: Host status block [00000007:00000002:(0000:0000:0000):(0000:0000)]
>>>> tg3 0000:03:01.0: eth0: 0: NAPI info [00000001:00000002:(0000:0000:01ff):0000:(00c8:0000:0000:0000)]
>>>> tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex
>>>> tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX
>>>> tg3 0000:03:01.0: tg3_stop_block timed out, ofs=4800 enable_bit=2
>>>> tg3 0000:03:01.0: eth0: Link is down
>>>> tg3 0000:03:01.0: eth0: Link is up at 1000 Mbps, full duplex
>>>> tg3 0000:03:01.0: eth0: Flow control is on for TX and on for RX
>>>>
>>>> If device not ready, then would not dump registers info.
>>>>
>>>> Signed-off-by: Joe Jin <joe.jin@oracle•com>
>>>> Signed-off-by: Guru Anbalagane <guru.anbalagane@oracle•com>
>>>> Reported-by: Gurudas Pai <gurudas.pai@oracle•com>
>>>> Cc: Matt Carlson <mcarlson@broadcom•com>
>>>> Cc: Michael Chan <mchan@broadcom•com>
>>>> ---
>>>> drivers/net/tg3.c | 11 +++++++++--
>>>>
>>> Maybe this one should based on net-next tree too, the tg3.c
>>> is lived below ./drivers/net/ethernet/broadcom/ in that tree.
>>>
>>> Thanks,
>>> Xiao Jiang
>>>> 1 files changed, 9 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
>>>> index 4a1374d..d79d344 100644
>>>> --- a/drivers/net/tg3.c
>>>> +++ b/drivers/net/tg3.c
>>>> @@ -5475,10 +5475,15 @@ static void tg3_process_error(struct tg3 *tp)
>>>> {
>>>> u32 val;
>>>> bool real_error = false;
>>>> + bool dump = true;
>>>>
>>>> if (tg3_flag(tp, ERROR_PROCESSED))
>>>> return;
>>>>
>>>> + /* If interface not ready then dont dump error */
>>>> + if (!netif_carrier_ok(tp->dev))
>>>> + dump = false;
>>
>> Would you still experience the problem if you did the following instead
>> of the above link check?
>>
>> if (tg3_flag(tp, INIT_COMPLETE))
>> dump = false;
>>
>>>> /* Check Flow Attention register */
>>>> val = tr32(HOSTCC_FLOW_ATTN);
>>>> if (val & ~HOSTCC_FLOW_ATTN_MBUF_LWM) {
>>>> @@ -5492,14 +5497,16 @@ static void tg3_process_error(struct tg3 *tp)
>>>> }
>>>>
>>>> if (tr32(RDMAC_STATUS) || tr32(WDMAC_STATUS)) {
>>>> - netdev_err(tp->dev, "DMA Status error. Resetting chip.\n");
>>>> + if (dump)
>>>> + netdev_err(tp->dev, "DMA Status error. Resetting chip.\n");
>>>> real_error = true;
>>>> }
>>>>
>>>> if (!real_error)
>>>> return;
>>>>
>>>> - tg3_dump_state(tp);
>>>> + if (dump)
>>>> + tg3_dump_state(tp);
>>>>
>>>> tg3_flag_set(tp, ERROR_PROCESSED);
>>>> schedule_work(&tp->reset_task);
>>>>
>>>
>>>
>>
prev parent reply other threads:[~2012-03-22 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 2:10 [PATCH] tg3: Dont dump registers if interface not ready Joe Jin
2011-09-29 6:50 ` Xiao Jiang
2011-10-05 2:14 ` Matt Carlson
2011-10-08 3:21 ` Joe Jin
2011-10-17 9:52 ` Joe Jin
2012-03-22 13:17 ` Luis Henriques [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vclw93mq.fsf@camandro.org \
--to=luis.henriques@canonical$(echo .)com \
--cc=greg.marsden@oracle$(echo .)com \
--cc=guru.anbalagane@oracle$(echo .)com \
--cc=gurudas.pai@oracle$(echo .)com \
--cc=jgq516@gmail$(echo .)com \
--cc=joe.jin@oracle$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mcarlson@broadcom$(echo .)com \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox