Subject: Re: [PATCH iproute2-next v2 3/8] dcb: app: modify dcb_app_table_remove_replaced() for dcb-rewr reuse

From: Petr Machata <[email-masked]>
Date: Tue, 30 May 2023 22:29:20 +0200

Petr Machata <[email-masked]> writes:

> Daniel Machon <[email-masked]> writes:
>
>> diff --git a/dcb/dcb.h b/dcb/dcb.h
>> index d40664f29dad..84ce95d5c1b2 100644
>> --- a/dcb/dcb.h
>> +++ b/dcb/dcb.h
>> @@ -56,11 +56,25 @@ void dcb_print_array_kw(const __u8 *array, size_t array_size,
>>  
>>  /* dcb_app.c */
>>  
>> +struct dcb_app_table {
>> +	struct dcb_app *apps;
>> +	size_t n_apps;
>> +	int attr;
>> +};
>> +
>>  int dcb_cmd_app(struct dcb *dcb, int argc, char **argv);
>>  enum ieee_attrs_app dcb_app_attr_type_get(__u8 selector);
>>  bool dcb_app_attr_type_validate(enum ieee_attrs_app type);
>>  bool dcb_app_selector_validate(enum ieee_attrs_app type, __u8 selector);
>>  
>> +bool dcb_app_pid_eq(const struct dcb_app *aa, const struct dcb_app *ab);

And I suspect this one does not need to be public at all?

>> +bool dcb_app_prio_eq(const struct dcb_app *aa, const struct dcb_app *ab);
>
> This function isn't necessary until 5/8, that's when it should be added.