Subject: Re: [PATCH v2 1/2] dt-bindings: net: wireless: ath9k: document endian check

From: Kalle Valo <[email-masked]>
Date: Mon, 17 Apr 2023 12:38:54 +0300

Krzysztof Kozlowski <[email-masked]> writes:

>> --- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
>> +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
>> @@ -44,6 +44,11 @@ properties:
>>  
>>    ieee80211-freq-limit: true
>>  
>> +  qca,endian-check:
>> +    $ref: /schemas/types.yaml#/definitions/flag
>> +    description:
>> +      Indicates that the EEPROM endianness should be checked
>
> Does not look like hardware property. Do not instruct what driver should
> or should not do. It's not the purpose of DT.

Also the documentation is vague and is not really telling anything new
what could be figured out from the property name, I would not be able to
understand just from this what value should be used.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches