From: "Toke Høiland-Jørgensen" <toke@toke•dk>
To: Jakub Kicinski <kuba@kernel•org>
Cc: jhs@mojatatu•com, xiyou.wangcong@gmail•com, jiri@resnulli•us,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, cake@lists•bufferbloat.net,
netdev@vger•kernel.org
Subject: Re: [PATCH net] sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb
Date: Thu, 01 Sep 2022 00:13:24 +0200 [thread overview]
Message-ID: <87wnao2ha3.fsf@toke.dk> (raw)
In-Reply-To: <166198321517.20200.12054704879498725145.git-patchwork-notify@kernel.org>
patchwork-bot+netdevbpf@kernel•org writes:
> Hello:
>
> This patch was applied to netdev/net.git (master)
> by Jakub Kicinski <kuba@kernel•org>:
>
> On Wed, 31 Aug 2022 11:21:03 +0200 you wrote:
>> When the GSO splitting feature of sch_cake is enabled, GSO superpackets
>> will be broken up and the resulting segments enqueued in place of the
>> original skb. In this case, CAKE calls consume_skb() on the original skb,
>> but still returns NET_XMIT_SUCCESS. This can confuse parent qdiscs into
>> assuming the original skb still exists, when it really has been freed. Fix
>> this by adding the __NET_XMIT_STOLEN flag to the return value in this case.
>>
>> [...]
>
> Here is the summary with links:
> - [net] sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb
> https://git.kernel.org/netdev/net/c/90fabae8a2c2
Ah, crossed streams (just sent v2[0]).
Hmm, okay, so as noted in the changelog to v2, just this patch will
break htb+cake (because htb will now skip htb_activate()); do you prefer
that I send a follow-up to fix HTB in this mode, or to revert this and
apply the fix to sfb in v2 instead?
-Toke
[0] https://lore.kernel.org/r/20220831215219.499563-1-toke@toke.dk
next prev parent reply other threads:[~2022-08-31 22:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 9:21 [PATCH net] sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb Toke Høiland-Jørgensen
2022-08-31 17:08 ` Eric Dumazet
2022-08-31 21:31 ` Toke Høiland-Jørgensen
2022-08-31 21:52 ` [PATCH net v2] sch_sfb: Don't assume the skb is still around after enqueueing to child Toke Høiland-Jørgensen
2022-09-02 11:30 ` patchwork-bot+netdevbpf
2022-09-05 17:55 ` Cong Wang
2022-09-05 19:05 ` Toke Høiland-Jørgensen
2022-08-31 22:00 ` [PATCH net] sch_cake: Return __NET_XMIT_STOLEN when consuming enqueued skb patchwork-bot+netdevbpf
2022-08-31 22:13 ` Toke Høiland-Jørgensen [this message]
2022-09-01 3:07 ` Jakub Kicinski
2022-09-01 9:20 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnao2ha3.fsf@toke.dk \
--to=toke@toke$(echo .)dk \
--cc=cake@lists$(echo .)bufferbloat.net \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox