From: "Toke Høiland-Jørgensen" <toke@toke•dk>
To: David Ahern <dsahern@gmail•com>
Cc: netdev@vger•kernel.org, Dave Taht <dave.taht@gmail•com>
Subject: Re: [PATCH v2 iproute2-next] sch_cake: Make gso-splitting configurable
Date: Mon, 13 Aug 2018 18:44:55 +0200 [thread overview]
Message-ID: <87wosucj20.fsf@toke.dk> (raw)
In-Reply-To: <f58a05f6-a544-c9b3-7ef7-ae83f37a682e@gmail.com>
David Ahern <dsahern@gmail•com> writes:
> On 8/13/18 5:36 AM, Toke Høiland-Jørgensen wrote:
>> This patch makes sch_cake's gso/gro splitting configurable
>> from userspace.
>>
>> To disable breaking apart superpackets in sch_cake:
>>
>> tc qdisc replace dev whatever root cake no-split-gso
>>
>> to enable:
>>
>> tc qdisc replace dev whatever root cake split-gso
>>
>> Signed-off-by: Toke Høiland-Jørgensen <toke@toke•dk>
>> Signed-off-by: Dave Taht <dave.taht@gmail•com>
>> ---
>
> applied to iproute2-next. Thanks
Great, thanks :)
> I think you also need to display it if the attribute is returned.
We already print 'split-gso' when it is set; this was previously decided
by the kernel, this change just makes it user-configurable...
-Toke
prev parent reply other threads:[~2018-08-13 19:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 11:36 [PATCH v2 iproute2-next] sch_cake: Make gso-splitting configurable Toke Høiland-Jørgensen
2018-08-13 14:45 ` David Ahern
2018-08-13 16:44 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wosucj20.fsf@toke.dk \
--to=toke@toke$(echo .)dk \
--cc=dave.taht@gmail$(echo .)com \
--cc=dsahern@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox