From: Kalle Valo <kvalo@codeaurora•org>
To: Javier Martinez Canillas <javier@osg•samsung.com>
Cc: linux-kernel@vger•kernel.org,
Julian Calaby <julian.calaby@gmail•com>,
Shengzhen Li <szli@marvell•com>,
Enric Balletbo i Serra <enric.balletbo@collabora•com>,
Amitkumar Karwar <akarwar@marvell•com>,
netdev@vger•kernel.org, linux-wireless@vger•kernel.org,
Nishant Sarmukadam <nishants@marvell•com>
Subject: Re: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file
Date: Fri, 10 Jun 2016 17:30:12 +0300 [thread overview]
Message-ID: <87wplxdsln.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1465232558-31678-3-git-send-email-javier@osg.samsung.com> (Javier Martinez Canillas's message of "Mon, 6 Jun 2016 13:02:37 -0400")
Javier Martinez Canillas <javier@osg•samsung.com> writes:
> From: Shengzhen Li <szli@marvell•com>
>
> Most cfg80211 operations are just a wrappers to functions defined in the
> sta_ioctl.c file, so for consistency move the .get_tx_power logic there.
>
> Signed-off-by: Shengzhen Li <szli@marvell•com>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell•com>
> [javier: update the subject line and commit message]
> Signed-off-by: Javier Martinez Canillas <javier@osg•samsung.com>
[...]
> --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> @@ -385,18 +385,10 @@ mwifiex_cfg80211_get_tx_power(struct wiphy *wiphy,
> int *dbm)
> {
> struct mwifiex_adapter *adapter = mwifiex_cfg80211_get_adapter(wiphy);
> - struct mwifiex_private *priv = mwifiex_get_priv(adapter,
> - MWIFIEX_BSS_ROLE_ANY);
> - int ret = mwifiex_send_cmd(priv, HostCmd_CMD_RF_TX_PWR,
> - HostCmd_ACT_GEN_GET, 0, NULL, true);
> -
> - if (ret < 0)
> - return ret;
> -
> - /* tx_power_level is set in HostCmd_CMD_RF_TX_PWR command handler */
> - *dbm = priv->tx_power_level;
> + struct mwifiex_private *priv;
>
> - return 0;
> + priv = mwifiex_get_priv(adapter, MWIFIEX_BSS_ROLE_ANY);
> + return mwifiex_get_tx_power(priv, dbm);
> }
So in patch 1 you added the patch and in patch 2 you move it to a
different location? That doesn't make any sense, can't you just fold the
two patches into one so that the function is added only once.
--
Kalle Valo
next prev parent reply other threads:[~2016-06-10 14:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 17:02 [PATCH v2 0/3] mwifiex: add .get_tx_power and .get_antenna cfg80211 operations Javier Martinez Canillas
2016-06-06 17:02 ` [PATCH v2 1/3] mwifiex: add a cfg80211 .get_tx_power operation callback Javier Martinez Canillas
2016-06-09 8:10 ` Enric Balletbo Serra
2016-07-05 13:29 ` [v2, " Kalle Valo
2016-06-06 17:02 ` [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file Javier Martinez Canillas
2016-06-09 8:11 ` Enric Balletbo Serra
2016-06-10 14:30 ` Kalle Valo [this message]
2016-06-10 14:37 ` Javier Martinez Canillas
2016-06-10 16:26 ` Amitkumar Karwar
[not found] ` <2b5e5833ecc74a2b9cd822e8455cd0af-uAViF8V/CPOq90oVIqnETxL4W9x8LtSr@public.gmane.org>
2016-06-10 19:33 ` Javier Martinez Canillas
[not found] ` <8dc6e64a-3429-4bed-e5c9-da6880eb9505-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-06-10 19:54 ` Kalle Valo
2016-06-21 14:47 ` Javier Martinez Canillas
[not found] ` <aeeb25f2-3253-0931-1e84-edc4590208b3-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-06-22 6:17 ` Kalle Valo
2016-06-22 12:57 ` Javier Martinez Canillas
2016-06-06 17:02 ` [PATCH v2 3/3] mwifiex: add get_antenna support for cfg80211 Javier Martinez Canillas
2016-06-09 8:12 ` Enric Balletbo Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wplxdsln.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora$(echo .)org \
--cc=akarwar@marvell$(echo .)com \
--cc=enric.balletbo@collabora$(echo .)com \
--cc=javier@osg$(echo .)samsung.com \
--cc=julian.calaby@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nishants@marvell$(echo .)com \
--cc=szli@marvell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox