From: Andi Kleen <andi@firstfloor•org>
To: Eric Dumazet <edumazet@google•com>
Cc: "David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, Thomas Lendacky <Thomas.Lendacky@amd•com>,
Ariel Elior <ariel.elior@qlogic•com>,
Michael Chan <mchan@broadcom•com>,
Prashant Sreedharan <prashant@broadcom•com>,
Rasesh Mody <rasesh.mody@qlogic•com>,
Sathya Perla <sathya.perla@emulex•com>,
Subbu Seetharaman <subbu.seetharaman@emulex•com>,
Ajit Khaparde <ajit.khaparde@emulex•com>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Jeff Kirsher <jeffrey.t.kirsher@intel•com>,
Amir Vadai <amirv@mellanox•com>,
Shradha Shah <sshah@solarflare•com>,
Shreyas Bhatewara <sbhatewara@vmware•com>
Subject: Re: [PATCH net-next 01/14] net: provide a per host RSS key generic infrastructure
Date: Sun, 16 Nov 2014 22:46:43 -0800 [thread overview]
Message-ID: <87wq6uiass.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <1416147798-16561-2-git-send-email-edumazet@google.com> (Eric Dumazet's message of "Sun, 16 Nov 2014 06:23:05 -0800")
Eric Dumazet <edumazet@google•com> writes:
> Some drivers use a constant (and well known key), some drivers use a random
> key per port, making bonding setups hard to tune. Well known keys increase
> attack surface, considering that number of queues is usually a power of two.
Wouldn't it be better to have some kernel facility to query on what
port a given mapping would end up rather than exporting
the key? Similar to querying the rounting table.
That would be more abstract.
> + {
> + .procname = "netdev_rss_key",
> + .data = &netdev_rss_key,
> + .maxlen = sizeof(int),
> + .mode = 0444,
Surely 0400 ? After all it's a kind a "secret"
-Andi
next prev parent reply other threads:[~2014-11-17 6:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-16 14:23 [PATCH net-next 00/14] net: provide common RSS key infrastructure Eric Dumazet
2014-11-16 14:23 ` [PATCH net-next 01/14] net: provide a per host RSS key generic infrastructure Eric Dumazet
2014-11-17 6:46 ` Andi Kleen [this message]
2014-11-17 6:58 ` Eric Dumazet
2014-11-16 14:23 ` [PATCH net-next 02/14] amd-xgbe: use netdev_rss_key_fill() helper Eric Dumazet
2014-11-16 14:23 ` [PATCH net-next 03/14] bnx2x: " Eric Dumazet
2014-11-16 14:23 ` [PATCH net-next 04/14] tg3: " Eric Dumazet
2014-11-16 14:23 ` [PATCH net-next 05/14] bna: " Eric Dumazet
2014-11-16 14:23 ` [PATCH net-next 06/14] be2net:use " Eric Dumazet
2014-11-16 14:23 ` [PATCH net-next 07/14] e100e: use " Eric Dumazet
2014-11-16 14:23 ` [PATCH net-next 08/14] fm10k: " Eric Dumazet
2014-11-16 14:23 ` [PATCH net-next 09/14] i40e: " Eric Dumazet
2014-11-16 14:23 ` [PATCH net-next 10/14] igb: " Eric Dumazet
2014-11-16 14:23 ` [PATCH net-next 11/14] ixgbe: " Eric Dumazet
2014-11-16 14:23 ` [PATCH net-next 12/14] mlx4: " Eric Dumazet
2014-11-22 21:49 ` Ben Hutchings
2014-11-22 23:58 ` Eric Dumazet
2014-11-23 1:24 ` [PATCH net-next] mlx4: fix mlx4_en_set_rxfh() Eric Dumazet
2014-11-23 16:53 ` Amir Vadai
2014-11-23 17:05 ` Eric Dumazet
2014-11-23 20:56 ` Joe Perches
2014-11-23 18:49 ` David Miller
2014-11-23 4:07 ` [PATCH net-next 12/14] mlx4: use netdev_rss_key_fill() helper Ben Hutchings
2014-11-23 4:14 ` Eric Dumazet
2014-11-16 14:23 ` [PATCH net-next 13/14] sfc: " Eric Dumazet
2014-11-16 14:23 ` [PATCH net-next 14/14] vmxnet3: " Eric Dumazet
2014-11-16 21:03 ` [PATCH net-next 00/14] net: provide common RSS key infrastructure David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wq6uiass.fsf@tassilo.jf.intel.com \
--to=andi@firstfloor$(echo .)org \
--cc=Thomas.Lendacky@amd$(echo .)com \
--cc=ajit.khaparde@emulex$(echo .)com \
--cc=amirv@mellanox$(echo .)com \
--cc=ariel.elior@qlogic$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=mchan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=prashant@broadcom$(echo .)com \
--cc=rasesh.mody@qlogic$(echo .)com \
--cc=sathya.perla@emulex$(echo .)com \
--cc=sbhatewara@vmware$(echo .)com \
--cc=sshah@solarflare$(echo .)com \
--cc=subbu.seetharaman@emulex$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox