From: Charalampos Mitrodimas <charmitro@posteo•net>
To: Tabrez Ahmed <tabreztalks@gmail•com>
Cc: allison.henderson@oracle•com, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
horms@kernel•org, gerd.rausch@oracle•com,
linux-rdma@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org,
syzbot+aae646f09192f72a68dc@syzkaller•appspotmail.com
Subject: Re: [PATCH net v2] rds: tcp: fix uninit-value in __inet_bind
Date: Tue, 17 Feb 2026 14:07:56 +0000 [thread overview]
Message-ID: <87y0krea4m.fsf@posteo.net> (raw)
In-Reply-To: <20260217135350.33641-1-tabreztalks@gmail.com>
Tabrez Ahmed <tabreztalks@gmail•com> writes:
> KMSAN reported an uninit-value access in __inet_bind() when binding
> an RDS TCP socket.
>
> The uninitialized memory originates from rds_tcp_conn_alloc(),
> which uses kmem_cache_alloc() to allocate the rds_tcp_connection structure.
>
> Specifically, the field 't_client_port_group' is incremented in
> rds_tcp_conn_path_connect() without being initialized first:
>
> if (++tc->t_client_port_group >= port_groups)
>
> Since kmem_cache_alloc() does not zero the memory, this field contains
> garbage, leading to the KMSAN report.
>
> Fix this by using kmem_cache_zalloc() to ensure the structure is
> zero-initialized upon allocation.
>
> Reported-by: syzbot+aae646f09192f72a68dc@syzkaller•appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=aae646f09192f72a68dc
> Tested-by: syzbot+aae646f09192f72a68dc@syzkaller•appspotmail.com
> Fixes: a20a6992558f ("net/rds: Encode cp_index in TCP source port")
>
> Signed-off-by: Tabrez Ahmed <tabreztalks@gmail•com>
> ---
Reviewed-by: Charalampos Mitrodimas <charmitro@posteo•net>
--
C. Mitrodimas
next prev parent reply other threads:[~2026-02-17 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 13:53 [PATCH net v2] rds: tcp: fix uninit-value in __inet_bind Tabrez Ahmed
2026-02-17 14:07 ` Charalampos Mitrodimas [this message]
2026-02-18 4:19 ` Allison Henderson
2026-02-19 15:05 ` Paolo Abeni
2026-02-19 15:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y0krea4m.fsf@posteo.net \
--to=charmitro@posteo$(echo .)net \
--cc=allison.henderson@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gerd.rausch@oracle$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=syzbot+aae646f09192f72a68dc@syzkaller$(echo .)appspotmail.com \
--cc=tabreztalks@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox