From: "Toke Høiland-Jørgensen" <toke@redhat•com>
To: Eric Dumazet <eric.dumazet@gmail•com>,
"David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>
Cc: netdev <netdev@vger•kernel.org>,
Eric Dumazet <edumazet@google•com>,
Eric Dumazet <eric.dumazet@gmail•com>,
"Ahmed S . Darwish" <a.darwish@linutronix•de>,
Sebastian Andrzej Siewior <bigeasy@linutronix•de>
Subject: Re: [PATCH net-next 2/2] net: sched: remove one pair of atomic operations
Date: Tue, 19 Oct 2021 12:46:44 +0200 [thread overview]
Message-ID: <87y26pguln.fsf@toke.dk> (raw)
In-Reply-To: <20211019003402.2110017-3-eric.dumazet@gmail.com>
Eric Dumazet <eric.dumazet@gmail•com> writes:
> From: Eric Dumazet <edumazet@google•com>
>
> __QDISC_STATE_RUNNING is only set/cleared from contexts owning qdisc lock.
>
> Thus we can use less expensive bit operations, as we were doing
> before commit f9eb8aea2a1e ("net_sched: transform qdisc running bit into a seqcount")
>
> Fixes: 29cbcd858283 ("net: sched: Remove Qdisc::running sequence counter")
> Signed-off-by: Eric Dumazet <edumazet@google•com>
> Cc: Ahmed S. Darwish <a.darwish@linutronix•de>
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix•de>
Tested-by: Toke Høiland-Jørgensen <toke@redhat•com>
next prev parent reply other threads:[~2021-10-19 10:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 0:34 [PATCH net-next 0/2] net: sched: fixes after recent qdisc->running changes Eric Dumazet
2021-10-19 0:34 ` [PATCH net-next 1/2] net: sched: fix logic error in qdisc_run_begin() Eric Dumazet
2021-10-19 6:50 ` Ido Schimmel
2021-10-19 7:51 ` Sebastian Andrzej Siewior
2021-10-19 10:45 ` Toke Høiland-Jørgensen
2021-10-20 7:32 ` Vlad Buslov
2021-10-20 8:11 ` Sebastian Andrzej Siewior
2021-10-20 8:36 ` Vlad Buslov
2021-10-19 0:34 ` [PATCH net-next 2/2] net: sched: remove one pair of atomic operations Eric Dumazet
2021-10-19 8:05 ` Sebastian Andrzej Siewior
2021-10-19 10:46 ` Toke Høiland-Jørgensen [this message]
2021-10-20 0:00 ` [PATCH net-next 0/2] net: sched: fixes after recent qdisc->running changes patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2021-10-21 16:22 [PATCH net-next 0/9] tcp: receive path optimizations Eric Dumazet
2021-10-21 16:22 ` [PATCH net-next 2/2] net: sched: remove one pair of atomic operations Eric Dumazet
2021-10-21 16:25 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y26pguln.fsf@toke.dk \
--to=toke@redhat$(echo .)com \
--cc=a.darwish@linutronix$(echo .)de \
--cc=bigeasy@linutronix$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox