From: "Bjørn Mork" <bjorn@mork•no>
To: Joe Perches <joe@perches•com>
Cc: netdev@vger•kernel.org
Subject: Re: [PATCH net-next] ipv6: log src and dst along with "udp checksum is 0"
Date: Tue, 25 Feb 2014 21:07:12 +0100 [thread overview]
Message-ID: <87y50z9csv.fsf@nemi.mork.no> (raw)
In-Reply-To: <1393357478.8716.35.camel@joe-AO722> (Joe Perches's message of "Tue, 25 Feb 2014 11:44:38 -0800")
Joe Perches <joe@perches•com> writes:
> On Tue, 2014-02-25 at 20:34 +0100, Bjørn Mork wrote:
>> These info messages are rather pointless without any means to identify
>> the source of the bogus packets. Logging the src and dst addresses
>> may help a bit.
> []
>> diff --git a/net/ipv6/ip6_checksum.c b/net/ipv6/ip6_checksum.c
> []
>> @@ -79,7 +79,8 @@ int udp6_csum_init(struct sk_buff *skb, struct udphdr *uh, int proto)
>> /* RFC 2460 section 8.1 says that we SHOULD log
>> this error. Well, it is reasonable.
>> */
>> - LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0\n");
>> + LIMIT_NETDEBUG(KERN_INFO "IPv6: udp checksum is 0 [%pI6c > %pI6c]\n",
>> + &ipv6_hdr(skb)->saddr, &ipv6_hdr(skb)->daddr);
>
> Might be useful to mirror the ipv4 form and add port #'s too.
Good point. New version coming up.
Bjørn
prev parent reply other threads:[~2014-02-25 20:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 19:34 [PATCH net-next] ipv6: log src and dst along with "udp checksum is 0" Bjørn Mork
2014-02-25 19:44 ` Joe Perches
2014-02-25 20:07 ` Bjørn Mork [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y50z9csv.fsf@nemi.mork.no \
--to=bjorn@mork$(echo .)no \
--cc=joe@perches$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox