From: Joachim Wiberg <troglobit@gmail•com>
To: Ido Schimmel <idosch@idosch•org>, netdev@vger•kernel.org
Cc: davem@davemloft•net, kuba@kernel•org, nikolay@nvidia•com,
roopa@nvidia•com, jiapeng.chong@linux•alibaba.com,
mlxsw@nvidia•com, Ido Schimmel <idosch@nvidia•com>
Subject: Re: [PATCH net] rtnetlink: Fix regression in bridge VLAN configuration
Date: Tue, 15 Jun 2021 19:06:46 +0200 [thread overview]
Message-ID: <87zgvroy55.fsf@gmail.com> (raw)
In-Reply-To: <20210609111753.1739008-1-idosch@idosch.org>
On Wed, Jun 09, 2021 at 14:17, Ido Schimmel <idosch@idosch•org> wrote:
> Cited commit started returning errors when notification info is not
> filled by the bridge driver, resulting in the following regression:
>
> # ip link add name br1 type bridge vlan_filtering 1
> # bridge vlan add dev br1 vid 555 self pvid untagged
> RTNETLINK answers: Invalid argument
>
> As long as the bridge driver does not fill notification info for the
> bridge device itself, an empty notification should not be considered as
> an error. This is explained in commit 59ccaaaa49b5 ("bridge: dont send
> notification when skb->len == 0 in rtnl_bridge_notify").
>
> Fix by removing the error and add a comment to avoid future bugs.
>
> Fixes: a8db57c1d285 ("rtnetlink: Fix missing error code in rtnl_bridge_notify()")
> Signed-off-by: Ido Schimmel <idosch@nvidia•com>
> Reviewed-by: Nikolay Aleksandrov <nikolay@nvidia•com>
Fix does indeed solve the same problem I encountered myself yesterday,
and bisected today. Tested successfully on a bridge setup with Marvell
88E6097 (DSA switch) for bridge offloading (not that it matters for this
particular fix).
Tested-by: Joachim Wiberg <troglobit@gmail•com>
Best regards
/Joachim
prev parent reply other threads:[~2021-06-15 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 11:17 [PATCH net] rtnetlink: Fix regression in bridge VLAN configuration Ido Schimmel
2021-06-09 22:00 ` patchwork-bot+netdevbpf
2021-06-15 17:06 ` Joachim Wiberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgvroy55.fsf@gmail.com \
--to=troglobit@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=idosch@idosch$(echo .)org \
--cc=idosch@nvidia$(echo .)com \
--cc=jiapeng.chong@linux$(echo .)alibaba.com \
--cc=kuba@kernel$(echo .)org \
--cc=mlxsw@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@nvidia$(echo .)com \
--cc=roopa@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox