Subject: Re: [Intel-gfx] [patch 13/30] drm/i915/lpe_audio: Remove pointless irq_to_desc() usage

From: Jani Nikula <[email-masked]>
Date: Fri, 11 Dec 2020 11:51:57 +0200

On Thu, 10 Dec 2020, Ville Syrjälä <[email-masked]> wrote:
> On Thu, Dec 10, 2020 at 08:25:49PM +0100, Thomas Gleixner wrote:
>> Nothing uses the result and nothing should ever use it in driver code.
>> 
>> Signed-off-by: Thomas Gleixner <[email-masked]>
>> Cc: Jani Nikula <[email-masked]>
>> Cc: Joonas Lahtinen <[email-masked]>
>> Cc: Rodrigo Vivi <[email-masked]>
>> Cc: David Airlie <[email-masked]>
>> Cc: Daniel Vetter <[email-masked]>
>> Cc: Pankaj Bharadiya <[email-masked]>
>> Cc: Chris Wilson <[email-masked]>
>> Cc: Wambui Karuga <[email-masked]>
>> Cc: [email-masked]
>> Cc: [email-masked]
>
> Reviewed-by: Ville Syrjälä <[email-masked]>

Thomas, I presume you want to merge this series as a whole.

Acked-by: Jani Nikula <[email-masked]>

for merging via whichever tree makes most sense. Please let us know if
you want us to pick this up via drm-intel instead.

>
>> ---
>>  drivers/gpu/drm/i915/display/intel_lpe_audio.c |    4 ----
>>  1 file changed, 4 deletions(-)
>> 
>> --- a/drivers/gpu/drm/i915/display/intel_lpe_audio.c
>> +++ b/drivers/gpu/drm/i915/display/intel_lpe_audio.c
>> @@ -297,13 +297,9 @@ int intel_lpe_audio_init(struct drm_i915
>>   */
>>  void intel_lpe_audio_teardown(struct drm_i915_private *dev_priv)
>>  {
>> -	struct irq_desc *desc;
>> -
>>  	if (!HAS_LPE_AUDIO(dev_priv))
>>  		return;
>>  
>> -	desc = irq_to_desc(dev_priv->lpe_audio.irq);
>> -
>>  	lpe_audio_platdev_destroy(dev_priv);
>>  
>>  	irq_free_desc(dev_priv->lpe_audio.irq);
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> [email-masked]
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center