Subject: Re: [RFC net-next 0/2] net: sched: add Flow Queue PIE AQM

From: Toke Høiland-Jørgensen <[email-masked]>
Date: Mon, 01 Apr 2019 14:04:19 +0200

Gautam Ramakrishnan <[email-masked]> writes:

> Flow Queue PIE packet scheduler
>
> This patch series implements the Flow Queue Proportional
> Integral Controller (FQ-PIE) active queue management
> algorithm. It is an enhancement over the PIE algorithm.
> It integrates the PIE aqm with a deficit round robin
> scheme.
>
> It is implemented over RFC 8033 aligned version of PIE.
> In this patch, Little's law is used for queue delay
> estimation like PIE. This patch doesn't yet have the
> timestamp based queue delay estimator like freebsd, that
> Dave Taht thinks is better.
>
> We are looking for suggestions on cleanups and
> improvements for this patch.

Is the fq_ part basically identical to fq_codel? Might make sense to
share some code in that case; might not be a trivial refactoring,
though...

-Toke