From: Nicolai Stange <nicstange@gmail•com>
To: Jakub Kicinski <jakub.kicinski@netronome•com>
Cc: netdev@vger•kernel.org, Nicolai Stange <nicstange@gmail•com>,
Christian Lamparter <chunkeey@gmail•com>
Subject: Re: [PATCH net-next 10/13] debugfs: constify argument to debugfs_real_fops()
Date: Thu, 03 Nov 2016 17:55:39 +0100 [thread overview]
Message-ID: <87zilgv6yc.fsf@gmail.com> (raw)
In-Reply-To: <1478181538-20778-11-git-send-email-jakub.kicinski@netronome.com> (Jakub Kicinski's message of "Thu, 3 Nov 2016 13:58:55 +0000")
Hi Jakub,
thanks for this.
However, the debugfs maintainer, Greg K-H, as well as the lkml is
missing from the To/Cc. Can you resend please?
Jakub Kicinski <jakub.kicinski@netronome•com> writes:
> seq_file users can only access const version of file pointer,
... because the ->file member of struct seq_operations is marked as such.
> make parameter to debugfs_real_fops() const.
>
> CC: Nicolai Stange <nicstange@gmail•com>
> CC: Christian Lamparter <chunkeey@gmail•com>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome•com>
> ---
> include/linux/debugfs.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
> index 4d3f0d1aec73..bf1907d96097 100644
> --- a/include/linux/debugfs.h
> +++ b/include/linux/debugfs.h
> @@ -52,7 +52,8 @@ struct debugfs_regset32 {
> * Must only be called under the protection established by
> * debugfs_use_file_start().
> */
> -static inline const struct file_operations *debugfs_real_fops(struct file *filp)
> +static inline const struct file_operations *
> +debugfs_real_fops(const struct file *filp)
> __must_hold(&debugfs_srcu)
> {
> /*
next prev parent reply other threads:[~2016-11-03 16:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 13:58 [PATCH net-next 00/13] ring reconfiguration and XDP support Jakub Kicinski
2016-11-03 13:58 ` [PATCH net-next 01/13] nfp: add support for ethtool .get_channels Jakub Kicinski
2016-11-03 13:58 ` [PATCH net-next 02/13] nfp: centralize runtime reconfiguration logic Jakub Kicinski
2016-11-03 13:58 ` [PATCH net-next 03/13] nfp: rename ring allocation helpers Jakub Kicinski
2016-11-03 13:58 ` [PATCH net-next 04/13] nfp: reuse ring helpers on .ndo_open() path Jakub Kicinski
2016-11-03 13:58 ` [PATCH net-next 05/13] nfp: loosen relation between rings and IRQs vectors Jakub Kicinski
2016-11-03 13:58 ` [PATCH net-next 06/13] nfp: add helper to reassign rings to IRQ vectors Jakub Kicinski
2016-11-03 13:58 ` [PATCH net-next 07/13] nfp: move RSS indirection table init into a separate function Jakub Kicinski
2016-11-03 13:58 ` [PATCH net-next 08/13] nfp: add support for ethtool .set_channels Jakub Kicinski
2016-11-03 13:58 ` [PATCH net-next 09/13] nfp: reorganize nfp_net_rx() to get packet offsets early Jakub Kicinski
2016-11-03 13:58 ` [PATCH net-next 10/13] debugfs: constify argument to debugfs_real_fops() Jakub Kicinski
2016-11-03 16:55 ` Nicolai Stange [this message]
2016-11-03 16:58 ` Jakub Kicinski
2016-11-03 13:58 ` [PATCH net-next 11/13] nfp: add XDP support in the driver Jakub Kicinski
2016-11-03 13:58 ` [PATCH net-next 12/13] nfp: remove unnecessary parameters from nfp_net_bpf_offload() Jakub Kicinski
2016-11-03 13:58 ` [PATCH net-next 13/13] nfp: add support for offload of XDP programs Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zilgv6yc.fsf@gmail.com \
--to=nicstange@gmail$(echo .)com \
--cc=chunkeey@gmail$(echo .)com \
--cc=jakub.kicinski@netronome$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox