Subject: Re: [PATCH] dm9601: warn on invalid mac address

From: Peter Korsgaard <[email-masked]>
Date: Tue, 06 Jan 2009 10:18:17 +0100

>>>>> "Wu" == Wu Fengguang <[email-masked]> writes:

Hi,

 Wu> Add warnings on invalid mac address to help disclose/debug problems.
 Wu> Signed-off-by: Wu Fengguang <[email-masked]>
 Wu> ---
 Wu>  drivers/net/usb/dm9601.c |   12 +++++++++++-
 Wu>  1 file changed, 11 insertions(+), 1 deletion(-)

 Wu> --- linux-2.6.orig/drivers/net/usb/dm9601.c
 Wu> +++ linux-2.6/drivers/net/usb/dm9601.c
 Wu> @@ -401,8 +401,12 @@ static int dm9601_set_mac_address(struct
 Wu>  	struct sockaddr *addr = p;
 Wu>  	struct usbnet *dev = netdev_priv(net);
 
 Wu> -	if (!is_valid_ether_addr(addr->sa_data))
 Wu> +	if (!is_valid_ether_addr(addr->sa_data)) {
 Wu> +		DECLARE_MAC_BUF(mac_buf);
 Wu> +		print_mac(mac_buf, addr->sa_data);
 Wu> +		dev_warn(&net->dev, "not setting invalid mac address %s\n", mac_buf);

This should be an error and not a warning.
Notice that print_mac returns the string, so you can do:

dev_err(&net->dev, "... %s", print_mac(mac_buf, addr->sa_data));
 
 Wu>  	memcpy(net->dev_addr, addr->sa_data, net->addr_len);
 Wu>  	dm_write_async(dev, DM_PHY_ADDR, net->addr_len, net->dev_addr);
 Wu> @@ -449,6 +453,12 @@ static int dm9601_bind(struct usbnet *de
 Wu>  	 */
 Wu>  	if (is_valid_ether_addr(mac))
 Wu>  		memcpy(dev->net->dev_addr, mac, ETH_ALEN);
 Wu> +	else {
 Wu> +		DECLARE_MAC_BUF(mac_buf);
 Wu> +		print_mac(mac_buf, mac);
 Wu> +		devdbg(dev, "EEPROM reported mac address %s is invalid,"
 Wu> +				" use the randomly generated one.", mac_buf);

And this should be a warning.

-- 
Bye, Peter Korsgaard