Subject: Re: [PATCH net-next v2] selftest: net: add some traceroute tests

From: David Ahern <[email-masked]>
Date: Tue, 5 Nov 2019 19:52:50 -0700

On 11/5/19 3:48 PM, Francesco Ruggeri wrote:
> Added the following traceroute tests.
> 
> IPV6:
> Verify that in this scenario
> 
>        ------------------------ N2
>         |                    |
>       ------              ------  N3  ----
>       | R1 |              | R2 |------|H2|
>       ------              ------      ----
>         |                    |
>        ------------------------ N1
>                  |
>                 ----
>                 |H1|
>                 ----
> 
> where H1's default route goes through R1 and R1's default route goes
> through R2 over N2, traceroute6 from H1 to H2 reports R2's address
> on N2 and not N1.
> 
> IPV4:
> Verify that traceroute from H1 to H2 shows 1.0.1.1 in this scenario
> 
>                    1.0.3.1/24
> ---- 1.0.1.3/24    1.0.1.1/24 ---- 1.0.2.1/24    1.0.2.4/24 ----
> |H1|--------------------------|R1|--------------------------|H2|
> ----            N1            ----            N2            ----
> 
> where net.ipv4.icmp_errors_use_inbound_ifaddr is set on R1 and
> 1.0.3.1/24 and 1.0.1.1/24 are respectively R1's primary and secondary
> address on N1.
> 
> v2: fixed some typos, and have bridge in R1 instead of R2 in IPV6 test.
> 
> Signed-off-by: Francesco Ruggeri <[email-masked]>
> ---
>  tools/testing/selftests/net/Makefile      |   2 +-
>  tools/testing/selftests/net/traceroute.sh | 322 ++++++++++++++++++++++
>  2 files changed, 323 insertions(+), 1 deletion(-)
>  create mode 100755 tools/testing/selftests/net/traceroute.sh
> 

Looks great. Thank you for adding this test script.

Reviewed-by: David Ahern <[email-masked]>