From: Dan Jurgens <danielj@nvidia•com>
To: Jason Wang <jasowang@redhat•com>
Cc: netdev@vger•kernel.org, mst@redhat•com,
alex.williamson@redhat•com, pabeni@redhat•com,
virtualization@lists•linux.dev, parav@nvidia•com,
shshitrit@nvidia•com, yohadt@nvidia•com,
xuanzhuo@linux•alibaba.com, eperezma@redhat•com,
shameerali.kolothum.thodi@huawei•com, jgg@ziepe•ca,
kevin.tian@intel•com, kuba@kernel•org, andrew+netdev@lunn•ch,
edumazet@google•com
Subject: Re: [PATCH net-next v7 09/12] virtio_net: Implement IPv4 ethtool flow rules
Date: Tue, 4 Nov 2025 11:04:35 -0600 [thread overview]
Message-ID: <8959bbcd-8845-439b-b986-e1d7007e3adf@nvidia.com> (raw)
In-Reply-To: <CACGkMEvNPzVkD8RQ84bU0yTSJeVNiq63jYbxCKhLQLpMPd0tZA@mail.gmail.com>
On 11/3/25 10:35 PM, Jason Wang wrote:
> On Tue, Nov 4, 2025 at 6:56 AM Daniel Jurgens <danielj@nvidia•com> wrote:
>>
>> Add support for IP_USER type rules from ethtool.
>>
>> Example:
>> $ ethtool -U ens9 flow-type ip4 src-ip 192.168.51.101 action -1
>> Added rule with ID 1
>>
>> The example rule will drop packets with the source IP specified.
>>
>> Signed-off-by: Daniel Jurgens <danielj@nvidia•com>
>> Reviewed-by: Parav Pandit <parav@nvidia•com>
>> Reviewed-by: Shahar Shitrit <shshitrit@nvidia•com>
>> Reviewed-by: Xuan Zhuo <xuanzhuo@linux•alibaba.com>
>> ---
>>
>> - memcpy(eth_m, &fs->m_u.ether_spec, sizeof(*eth_m));
>> - memcpy(eth_k, &fs->h_u.ether_spec, sizeof(*eth_k));
>> + if (num_hdrs > 1) {
>> + eth_m->h_proto = cpu_to_be16(0xffff);
>> + eth_k->h_proto = cpu_to_be16(ETH_P_IP);
>
> Do we need to check IPV6 here?
That comes in a subsequent patch. None of this is actually reachable
until we set the get operations in the last patch. So I think it's fine.
>
> Thanks
>
next prev parent reply other threads:[~2025-11-04 17:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 22:55 [PATCH net-next v7 00/12] virtio_net: Add ethtool flow rules support Daniel Jurgens
2025-11-03 22:55 ` [PATCH net-next v7 01/12] virtio_pci: Remove supported_cap size build assert Daniel Jurgens
2025-11-03 22:55 ` [PATCH net-next v7 02/12] virtio: Add config_op for admin commands Daniel Jurgens
2025-11-03 22:55 ` [PATCH net-next v7 03/12] virtio: Expose generic device capability operations Daniel Jurgens
2025-11-03 22:55 ` [PATCH net-next v7 04/12] virtio: Expose object create and destroy API Daniel Jurgens
2025-11-03 22:55 ` [PATCH net-next v7 05/12] virtio_net: Query and set flow filter caps Daniel Jurgens
2025-11-04 4:33 ` Jason Wang
2025-11-04 17:10 ` Dan Jurgens
2025-11-05 14:19 ` Simon Horman
2025-11-07 3:38 ` Dan Jurgens
2025-11-03 22:55 ` [PATCH net-next v7 06/12] virtio_net: Create a FF group for ethtool steering Daniel Jurgens
2025-11-03 22:55 ` [PATCH net-next v7 07/12] virtio_net: Implement layer 2 ethtool flow rules Daniel Jurgens
2025-11-04 4:34 ` Jason Wang
2025-11-04 17:07 ` Dan Jurgens
2025-11-03 22:55 ` [PATCH net-next v7 08/12] virtio_net: Use existing classifier if possible Daniel Jurgens
2025-11-03 22:55 ` [PATCH net-next v7 09/12] virtio_net: Implement IPv4 ethtool flow rules Daniel Jurgens
2025-11-04 4:35 ` Jason Wang
2025-11-04 17:04 ` Dan Jurgens [this message]
2025-11-03 22:55 ` [PATCH net-next v7 10/12] virtio_net: Add support for IPv6 ethtool steering Daniel Jurgens
2025-11-03 22:55 ` [PATCH net-next v7 11/12] virtio_net: Add support for TCP and UDP ethtool rules Daniel Jurgens
2025-11-03 22:55 ` [PATCH net-next v7 12/12] virtio_net: Add get ethtool flow rules ops Daniel Jurgens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8959bbcd-8845-439b-b986-e1d7007e3adf@nvidia.com \
--to=danielj@nvidia$(echo .)com \
--cc=alex.williamson@redhat$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=edumazet@google$(echo .)com \
--cc=eperezma@redhat$(echo .)com \
--cc=jasowang@redhat$(echo .)com \
--cc=jgg@ziepe$(echo .)ca \
--cc=kevin.tian@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=parav@nvidia$(echo .)com \
--cc=shameerali.kolothum.thodi@huawei$(echo .)com \
--cc=shshitrit@nvidia$(echo .)com \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
--cc=yohadt@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox