From: Przemek Kitszel <przemyslaw.kitszel@intel•com>
To: Leon Romanovsky <leon@kernel•org>
Cc: Simon Horman <horms@kernel•org>, <netdev@vger•kernel.org>,
<jesse.brandeburg@intel•com>,
Karol Kolacinski <karol.kolacinski@intel•com>,
<anthony.l.nguyen@intel•com>, <intel-wired-lan@lists•osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH v2 iwl-next 1/9] ice: use ice_pf_src_tmr_owned where available
Date: Tue, 22 Aug 2023 17:56:25 +0200 [thread overview]
Message-ID: <8a0e05ed-ae10-ba2f-5859-003cd02fba9c@intel.com> (raw)
In-Reply-To: <20230822154810.GM6029@unreal>
On 8/22/23 17:48, Leon Romanovsky wrote:
> On Tue, Aug 22, 2023 at 04:44:29PM +0200, Przemek Kitszel wrote:
>> On 8/22/23 16:13, Leon Romanovsky wrote:
>>> On Tue, Aug 22, 2023 at 09:02:11AM +0200, Simon Horman wrote:
>>>> On Sat, Aug 19, 2023 at 02:52:49PM +0300, Leon Romanovsky wrote:
>>>>> On Thu, Aug 17, 2023 at 04:17:38PM +0200, Karol Kolacinski wrote:
>>>>>> The ice_pf_src_tmr_owned() macro exists to check the function capability
>>>>>> bit indicating if the current function owns the PTP hardware clock.
>>>>>
>>>>> This is first patch in the series, but I can't find mentioned macro.
>>>>> My net-next is based on 5b0a1414e0b0 ("Merge branch 'smc-features'")
>>>>> ➜ kernel git:(net-next) git grep ice_pf_src_tmr_owned
>>>>> shows nothing.
>>>>>
>>>>> On which branch is it based?
>>>>
>>>> Hi Leon,
>>>>
>>>> My assumption is that it is based on the dev-queue branch of
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git
>>>
>>> So should netdev readers review it or wait till Intel folks perform
>>> first pass on it?
>>
>> Most of the time Intel folks would be first to review, if only because of
>> our pre-IWL processes or pure familiarity/interest in given piece.
>>
>> For this particular series, it is about right "codewise" since v1, so you
>> are welcome for an insightful look at v3
>> (I didn't provided my RBs so far because of "metadata" issues :),
>> will take a fresh look, but you don't need to wait).
>>
>>
>> General idea for CC'ing netdev for IWL-targeted patches is to have open
>> develompent process.
>> Quality should be already as for netdev posting.
>> Our VAL picks up patches for testing from here when Tony marks them so.
>>
>> That's what I could say for review process.
>>
>> "Maintainers stuff", I *guess*, is:
>> after review&test Tony Requests netdev Maintainers to Pull
>> (and throttles outgoing stuff by doing so to pace agreed upon).
>> At that stage is a last moment for (late?) review, welcomed as always.
>
> It means that we (netdev@... ) will see "same" patches twice, am I right?
That's true.
>
> Thanks
>
>>
>>
>>
>>>
>>> Thanks
>>> _______________________________________________
>>> Intel-wired-lan mailing list
>>> Intel-wired-lan@osuosl•org
>>> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
>>
>>
next prev parent reply other threads:[~2023-08-22 15:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 14:17 [PATCH v2 iwl-next 0/9] ice: fix timestamping in reset process Karol Kolacinski
2023-08-17 14:17 ` [PATCH v2 iwl-next 1/9] ice: use ice_pf_src_tmr_owned where available Karol Kolacinski
2023-08-18 11:10 ` Przemek Kitszel
2023-08-19 11:52 ` Leon Romanovsky
2023-08-22 7:02 ` Simon Horman
2023-08-22 14:13 ` Leon Romanovsky
2023-08-22 14:44 ` [Intel-wired-lan] " Przemek Kitszel
2023-08-22 15:48 ` Leon Romanovsky
2023-08-22 15:56 ` Przemek Kitszel [this message]
2023-08-22 16:06 ` Leon Romanovsky
2023-08-22 16:53 ` Jakub Kicinski
2023-08-22 17:15 ` Leon Romanovsky
2023-08-17 14:17 ` [PATCH v2 iwl-next 2/9] ice: introduce PTP state machine Karol Kolacinski
2023-08-17 14:17 ` [PATCH v2 iwl-next 3/9] ice: pass reset type to PTP reset functions Karol Kolacinski
2023-08-17 14:17 ` [PATCH v2 iwl-next 4/9] ice: rename PTP functions and fields Karol Kolacinski
2023-08-17 14:17 ` [PATCH v2 iwl-next 5/9] ice: factor out ice_ptp_rebuild_owner() Karol Kolacinski
2023-08-17 14:17 ` [PATCH v2 iwl-next 6/9] ice: remove ptp_tx ring parameter flag Karol Kolacinski
2023-08-17 14:17 ` [PATCH v2 iwl-next 7/9] ice: modify tstamp_config only during TS mode set Karol Kolacinski
2023-08-17 14:17 ` [PATCH v2 iwl-next 8/9] ice: restore timestamp configuration after reset Karol Kolacinski
2023-08-17 14:17 ` [PATCH v2 iwl-next 9/9] ice: stop destroying and reinitalizing Tx tracker during reset Karol Kolacinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a0e05ed-ae10-ba2f-5859-003cd02fba9c@intel.com \
--to=przemyslaw.kitszel@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=karol.kolacinski@intel$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox