From: Thor Thayer <thor.thayer@linux•intel.com>
To: Dalon Westergreen <dwesterg@gmail•com>,
netdev@vger•kernel.org, dinguyen@kernel•org
Cc: Dalon Westergreen <dalon.westergreen@intel•com>
Subject: Re: [PATCH net-next 4/8] net: eth: altera: tse: add optional function to start tx dma
Date: Thu, 15 Nov 2018 17:12:09 -0600 [thread overview]
Message-ID: <8eb2096e-e436-5406-dac9-17ce36eed237@linux.intel.com> (raw)
In-Reply-To: <20181115005047.28464-5-dwesterg@gmail.com>
On 11/14/18 6:50 PM, Dalon Westergreen wrote:
> From: Dalon Westergreen <dalon.westergreen@intel•com>
>
> Allow for optional start up of tx dma if the start_txdma
> function is defined in altera_dmaops.
>
> Signed-off-by: Dalon Westergreen <dalon.westergreen@intel•com>
> ---
> drivers/net/ethernet/altera/altera_tse.h | 1 +
> drivers/net/ethernet/altera/altera_tse_main.c | 5 +++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h
> index d5b97e02e6d6..7f246040135d 100644
> --- a/drivers/net/ethernet/altera/altera_tse.h
> +++ b/drivers/net/ethernet/altera/altera_tse.h
> @@ -412,6 +412,7 @@ struct altera_dmaops {
> int (*init_dma)(struct altera_tse_private *priv);
> void (*uninit_dma)(struct altera_tse_private *priv);
> void (*start_rxdma)(struct altera_tse_private *priv);
> + void (*start_txdma)(struct altera_tse_private *priv);
> };
>
> /* This structure is private to each device.
> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
> index 0c0e8f9bba9b..f6b6a14b1ce9 100644
> --- a/drivers/net/ethernet/altera/altera_tse_main.c
> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
> @@ -1256,6 +1256,9 @@ static int tse_open(struct net_device *dev)
>
> priv->dmaops->start_rxdma(priv);
>
> + if (priv->dmaops->start_txdma)
> + priv->dmaops->start_txdma(priv);
> +
> /* Start MAC Rx/Tx */
> spin_lock(&priv->mac_cfg_lock);
> tse_set_mac(priv, true);
> @@ -1658,6 +1661,7 @@ static const struct altera_dmaops altera_dtype_sgdma = {
> .init_dma = sgdma_initialize,
> .uninit_dma = sgdma_uninitialize,
> .start_rxdma = sgdma_start_rxdma,
> + .start_txdma = NULL,
> };
>
> static const struct altera_dmaops altera_dtype_msgdma = {
> @@ -1677,6 +1681,7 @@ static const struct altera_dmaops altera_dtype_msgdma = {
> .init_dma = msgdma_initialize,
> .uninit_dma = msgdma_uninitialize,
> .start_rxdma = msgdma_start_rxdma,
> + .start_txdma = NULL,
> };
>
> static const struct of_device_id altera_tse_ids[] = {
>
Acked-by: Thor Thayer <thor.thayer@linux•intel.com>
next prev parent reply other threads:[~2018-11-16 9:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 0:50 [PATCH net-next 0/8] net: eth: altera: tse: Add PTP and mSGDMA prefetcher Dalon Westergreen
2018-11-15 0:50 ` [PATCH net-next 1/8] net: eth: altera: tse_start_xmit ignores tx_buffer call response Dalon Westergreen
2018-11-15 23:07 ` Thor Thayer
2018-11-17 4:38 ` David Miller
2018-11-17 15:29 ` Westergreen, Dalon
2018-11-15 0:50 ` [PATCH net-next 2/8] net: eth: altera: set rx and tx ring size before init_dma call Dalon Westergreen
2018-11-15 23:08 ` Thor Thayer
2018-11-15 0:50 ` [PATCH net-next 3/8] net: eth: altera: tse: fix altera_dmaops declaration Dalon Westergreen
2018-11-15 23:10 ` Thor Thayer
2018-11-15 0:50 ` [PATCH net-next 4/8] net: eth: altera: tse: add optional function to start tx dma Dalon Westergreen
2018-11-15 23:12 ` Thor Thayer [this message]
2018-11-15 0:50 ` [PATCH net-next 5/8] net: eth: altera: tse: Move common functions to altera_utils Dalon Westergreen
2018-11-15 23:14 ` Thor Thayer
2018-11-15 0:50 ` [PATCH net-next 6/8] net: eth: altera: tse: add support for ptp and timestamping Dalon Westergreen
2018-11-15 3:24 ` Richard Cochran
[not found] ` <729c71a95091f0902396be8b6c73409cd1e8ae9d.camel@gmail.com>
2018-11-16 2:14 ` Richard Cochran
2018-11-16 13:33 ` Dalon Westergreen
2018-11-16 14:48 ` Dalon Westergreen
2018-11-16 18:37 ` Richard Cochran
2018-11-15 0:50 ` [PATCH net-next 7/8] net: eth: altera: tse: add msgdma prefetcher Dalon Westergreen
2018-11-16 15:20 ` Thor Thayer
2018-11-28 0:26 ` Dalon Westergreen
2018-11-15 0:50 ` [PATCH net-next 8/8] net: eth: altera: tse: update devicetree bindings documentation Dalon Westergreen
2018-11-15 23:49 ` Thor Thayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eb2096e-e436-5406-dac9-17ce36eed237@linux.intel.com \
--to=thor.thayer@linux$(echo .)intel.com \
--cc=dalon.westergreen@intel$(echo .)com \
--cc=dinguyen@kernel$(echo .)org \
--cc=dwesterg@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox