Subject: RE: [RFC PATCH v1 00/19] rtw88: Add SDIO support

From: Ping-Ke Shih <[email-masked]>
Date: Thu, 29 Dec 2022 04:19:47 +0000

> -----Original Message-----
> From: Martin Blumenstingl <[email-masked]>
> Sent: Wednesday, December 28, 2022 7:30 AM
> To: [email-masked]
> Cc: Yan-Hsuan Chuang <[email-masked]>; Kalle Valo <[email-masked]>; Ulf Hansson
> <[email-masked]>; [email-masked]; [email-masked];
> [email-masked]; Chris Morgan <[email-masked]>; Nitin Gupta <[email-masked]>;
> Neo Jou <[email-masked]>; Ping-Ke Shih <[email-masked]>; Jernej Skrabec <[email-masked]>;
> Martin Blumenstingl <[email-masked]>
> Subject: [RFC PATCH v1 00/19] rtw88: Add SDIO support
> 
> Recently the rtw88 driver has gained locking support for the "slow" bus
> types (USB, SDIO) as part of USB support. Thanks to everyone who helped
> make this happen!
> 
> Based on the USB work (especially the locking part and various
> bugfixes) this series adds support for SDIO based cards. It's the
> result of a collaboration between Jernej and myself. Neither of us has
> access to the rtw88 datasheets. All of our work is based on studying
> the RTL8822BS and RTL8822CS vendor drivers and trial and error.
> 
> Jernej and myself have tested this with RTL8822BS and RTL8822CS cards.
> Other users have confirmed that RTL8821CS support is working as well.
> RTL8723DS may also work (we tried our best to handle rtw_chip_wcpu_11n
> where needed) but has not been tested at this point.
> 
> Jernej's results with a RTL8822BS:
> - Main functionality works
> - Had a case where no traffic got across the link until he issued a
>   scan
> 
> My results with a RTL8822CS:
> - 2.4GHz and 5GHz bands are both working
> - TX throughput on a 5GHz network is between 50 Mbit/s and 90 Mbit/s
> - RX throughput on a 5GHz network is at 19 Mbit/s

I have a suggestion about RX throughput, please check below registers with
vendor driver:

REG_RXDMA_AGG_PG_TH
REG_TXDMA_PQ_MAP(0x10c) BIT_RXDMA_AGG_EN (bit2)
REG_RXDMA_MODE(0290)  BIT_DMA_MODE (bit1)

Try to adjust AGG_PG_TH to see if it can help.

--
Ping-Ke