From: Dmitrii Shcherbakov <fw.dmitrii@yandex•com>
To: Jesper Dangaard Brouer <brouer@redhat•com>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Phil Sutter <psutter@redhat•com>,
Stephen Hemminger <stephen@networkplumber•org>
Subject: Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev <device_name> ' command
Date: Thu, 17 Dec 2015 12:45:33 +0300 [thread overview]
Message-ID: <907481450345533@web24h.yandex.ru> (raw)
In-Reply-To: <740111450344461@web24h.yandex.ru>
Jesper,
Sorry, it seems that I accidentally sent out an unfinished e-mail.
>I don't think your patch should contain this cleanup of "b4".
It seems that b3 is only used for the legacy overhead part and if I remove it, b3 is not going to be used. So I figured I remove b4 put b3 instead.
administrator@ubuntu:~/src/iproute2/tc$ git rev-parse HEAD
654ae881de57467642c8c2ed16ffc3a8d57fafa2
administrator@ubuntu:~/src/iproute2/tc$ grep -nHP -B 3 'b3' q_htb.c
q_htb.c-273- __u64 rate64, ceil64;
q_htb.c-274- SPRINT_BUF(b1);
q_htb.c-275- SPRINT_BUF(b2);
q_htb.c:276: SPRINT_BUF(b3);
--
q_htb.c-317- sprint_size(buffer, b1),
q_htb.c-318- 1<<hopt->rate.cell_log,
q_htb.c-319- sprint_size(hopt->rate.mpu&0xFF, b2),
q_htb.c:320: sprint_size((hopt->rate.mpu>>8)&0xFF, b3));
--
q_htb.c-322- sprint_size(cbuffer, b1),
q_htb.c-323- 1<<hopt->ceil.cell_log,
q_htb.c-324- sprint_size(hopt->ceil.mpu&0xFF, b2),
q_htb.c:325: sprint_size((hopt->ceil.mpu>>8)&0xFF, b3));
administrator@ubuntu:~/src/iproute2/tc$ grep -nHP -B 3 'b4' q_htb.c
q_htb.c-274- SPRINT_BUF(b1);
q_htb.c-275- SPRINT_BUF(b2);
q_htb.c-276- SPRINT_BUF(b3);
q_htb.c:277: SPRINT_BUF(b4);
--
q_htb.c-311- cbuffer = tc_calc_xmitsize(ceil64, hopt->cbuffer);
q_htb.c-312- linklayer = (hopt->rate.linklayer & TC_LINKLAYER_MASK);
q_htb.c-313- if (linklayer > TC_LINKLAYER_ETHERNET || show_details)
q_htb.c:314: fprintf(f, "linklayer %s ", sprint_linklayer(linklayer, b4));
Thanks,
Dima
next prev parent reply other threads:[~2015-12-17 9:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 11:09 [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev <device_name> ' command Dmitrii Shcherbakov
2015-12-16 15:15 ` Jesper Dangaard Brouer
2015-12-16 16:04 ` Phil Sutter
2015-12-16 20:56 ` Dmitrii Shcherbakov
2015-12-18 16:39 ` Dmitrii Shcherbakov
2015-12-18 16:55 ` Phil Sutter
2015-12-18 21:45 ` Dmitrii Shcherbakov
2015-12-22 5:45 ` Stephen Hemminger
2015-12-17 9:27 ` Dmitrii Shcherbakov
2015-12-17 9:45 ` Dmitrii Shcherbakov [this message]
2015-12-17 13:11 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=907481450345533@web24h.yandex.ru \
--to=fw.dmitrii@yandex$(echo .)com \
--cc=brouer@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=psutter@redhat$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox