Subject: Re: [PATCH iwl-next v10 03/14] virtchnl: add enumeration for the rxdid format

From: Alexander Lobakin <[email-masked]>
Date: Wed, 21 Aug 2024 15:30:57 +0200

From: Wojciech Drewek <[email-masked]>
Date: Wed, 21 Aug 2024 14:15:28 +0200

> From: Jacob Keller <[email-masked]>
> 
> Support for allowing VF to negotiate the descriptor format requires that
> the VF specify which descriptor format to use when requesting Rx queues.
> The VF is supposed to request the set of supported formats via the new
> VIRTCHNL_OP_GET_SUPPORTED_RXDIDS, and then set one of the supported
> formats in the rxdid field of the virtchnl_rxq_info structure.
> 
> The virtchnl.h header does not provide an enumeration of the format
> values. The existing implementations in the PF directly use the values
> from the DDP package.
> 
> Make the formats explicit by defining an enumeration of the RXDIDs.
> Provide an enumeration for the values as well as the bit positions as
> returned by the supported_rxdids data from the
> VIRTCHNL_OP_GET_SUPPORTED_RXDIDS.
> 
> Signed-off-by: Jacob Keller <[email-masked]>
> Reviewed-by: Wojciech Drewek <[email-masked]>
> Reviewed-by: Rahul Rameshbabu <[email-masked]>
> Reviewed-by: Simon Horman <[email-masked]>

Reviewed-by: Alexander Lobakin <[email-masked]>

> Signed-off-by: Mateusz Polchlopek <[email-masked]>
> Signed-off-by: Wojciech Drewek <[email-masked]>

Thanks,
Olek