Subject: Re: [PATCH v4 01/17] dt-bindings: net: wireless: cc33xx: Add ti,cc33xx.yaml

From: Krzysztof Kozlowski <[email-masked]>
Date: Tue, 29 Oct 2024 18:28:52 +0100

On 29/10/2024 18:23, Michael Nemanov wrote:
> Add device-tree bindings for the CC33xx family.
> 
> Signed-off-by: Michael Nemanov <[email-masked]>
> ---
>  .../bindings/net/wireless/ti,cc33xx.yaml      | 59 +++++++++++++++++++
>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml b/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml
> new file mode 100644
> index 000000000000..12a0a2f52f44
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/wireless/ti,cc33xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments CC33xx Wireless LAN Controller
> +
> +maintainers:
> +  - Michael Nemanov <[email-masked]>
> +
> +description:
> +  The CC33xx is a family of IEEE 802.11ax chips from Texas Instruments.
> +  These chips must be connected via SDIO and support in-band / out-of-band IRQ.
> +
> +properties:
> +  $nodename:
> +    pattern: "^wifi@2"

This wasn't here, please drop.

> +
> +  compatible:
> +    oneOf:

Why oneOf appeared? Do you plan to grow it?

> +      - items:
> +          - enum:
> +              - ti,cc3300
> +              - ti,cc3301
> +              - ti,cc3350
> +              - ti,cc3351
> +          - const: ti,cc33xx

And how cc33xx could appear? That's a no. Generic compatibles are not
allowed. Please do not introduce some completely different changes than
asked for.

Your changelog does not explain these three. "Fixed compatibility" is
way too vague, especially that you do not fix anything here.

> +
> +  reg:
> +    const: 2
> +

Best regards,
Krzysztof