From: Heiner Kallweit <hkallweit1@gmail•com>
To: David Miller <davem@davemloft•net>
Cc: andrew@lunn•ch, f.fainelli@gmail•com, nic_swsd@realtek•com,
netdev@vger•kernel.org
Subject: Re: [PATCH net v2 0/2] net: phy: fix WoL handling when suspending the PHY
Date: Fri, 28 Sep 2018 21:41:26 +0200 [thread overview]
Message-ID: <97fefc19-b79f-8e75-2eae-61eb44032592@gmail.com> (raw)
In-Reply-To: <20180926.200435.34563447557737934.davem@davemloft.net>
On 27.09.2018 05:04, David Miller wrote:
> From: Heiner Kallweit <hkallweit1@gmail•com>
> Date: Mon, 24 Sep 2018 21:58:04 +0200
>
>> phy_suspend doesn't always recognize that WoL is enabled and therefore
>> suspends the PHY when it should not. First idea to address the issue
>> was to reuse checks used in mdio_bus_phy_may_suspend which check
>> whether relevant devices are wakeup-enabled.
>> Florian raised some concerns because drivers may enable wakeup even if
>> WoL isn't enabled (e.g. certain USB network drivers).
>>
>> The new approach focuses on reducing the risk to break existing stuff.
>> We add a flag wol_enabled to struct net_device which is set in
>> ethtool_set_wol(). Then this flag is checked in phy_suspend().
>> This doesn't cover 100% of the cases yet (e.g. if WoL is enabled w/o
>> explicit configuration), but it covers the most relevant cases with
>> very little risk of regressions.
>>
>> v2:
>> - Fix a typo
>
> Series applied, thanks.
>
> Please deal with the extra 4 byte size of net_device in net-next.
>
Sure. Next week I'm on travel, will do it the week after.
> Thanks.
>
prev parent reply other threads:[~2018-09-29 2:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 19:58 [PATCH net v2 0/2] net: phy: fix WoL handling when suspending the PHY Heiner Kallweit
2018-09-24 19:58 ` [PATCH net v2 1/2] net: core: add member wol_enabled to struct net_device Heiner Kallweit
2018-09-24 21:39 ` Florian Fainelli
2018-09-25 8:28 ` Michal Kubecek
2018-09-25 17:30 ` Heiner Kallweit
2018-09-27 3:04 ` [PATCH net v2 0/2] net: phy: fix WoL handling when suspending the PHY David Miller
2018-09-28 19:41 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97fefc19-b79f-8e75-2eae-61eb44032592@gmail.com \
--to=hkallweit1@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nic_swsd@realtek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox