Subject: Re: [PATCH 1/6] pch_gbe: print invalid MAC address during probe

From: Alexander Stein <[email-masked]>
Date: Wed, 28 May 2014 11:34:20 +0200

On Monday 26 May 2014 09:24:28, Joe Perches wrote:
> On Mon, 2014-05-26 at 15:40 +0200, Alexander Stein wrote:
> > show the actual offending MAC address instead of just
> > rejecting it
> []
> > diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> []
> > @@ -2674,6 +2674,7 @@ static int pch_gbe_probe(struct pci_dev *pdev,
> >  		 */
> >  		dev_err(&pdev->dev, "Invalid MAC address, "
> >  		                    "interface disabled.\n");
> > +		dev_err(&pdev->dev, "%pM\n", adapter->hw.mac.addr);
> 
> Nicer I think on a single line
> using just one dev_err
> 
> 		dev_err(&pdev->dev, "Invalid MAC %pM - interface disabled\n",
> 			adapter->hw.mac.addr);

Yep, I'll send a v2 if there is some more feedback on the other patches.

Best regards,
Alexander