From: David Laight <David.Laight@ACULAB•COM>
To: 'Marcelo Ricardo Leitner' <marcelo.leitner@gmail•com>,
Xin Long <lucien.xin@gmail•com>
Cc: network dev <netdev@vger•kernel.org>,
"linux-sctp@vger•kernel.org" <linux-sctp@vger•kernel.org>,
Neil Horman <nhorman@tuxdriver•com>,
"davem@davemloft•net" <davem@davemloft•net>
Subject: RE: [PATCHv3 net-next 2/5] sctp: add pf_expose per netns and sock and asoc
Date: Fri, 25 Oct 2019 09:00:45 +0000 [thread overview]
Message-ID: <995e44322af74c41bbff2c77338f83bf@AcuMS.aculab.com> (raw)
In-Reply-To: <20191025032337.GC4326@localhost.localdomain>
From: Marcelo Ricardo Leitner
> Sent: 25 October 2019 04:24
...
> > @@ -5521,8 +5522,16 @@ static int sctp_getsockopt_peer_addr_info(struct sock *sk, int len,
> >
> > transport = sctp_addr_id2transport(sk, &pinfo.spinfo_address,
> > pinfo.spinfo_assoc_id);
> > - if (!transport)
> > - return -EINVAL;
> > + if (!transport) {
> > + retval = -EINVAL;
> > + goto out;
> > + }
> > +
> > + if (transport->state == SCTP_PF &&
> > + transport->asoc->pf_expose == SCTP_PF_EXPOSE_DISABLE) {
> > + retval = -EACCES;
> > + goto out;
> > + }
>
> As is on v3, this is NOT an UAPI violation. The user has to explicitly
> set the system or the socket into the disabled state in order to
> trigger this new check.
Only because the default isn't to be backwards compatible with the
old kernel and old applications.
An old application running on a system that has the protocol parts of
PF enabled mustn't see any PF events, states or obscure error returns.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2019-10-25 9:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 6:14 [PATCHv3 net-next 0/5] sctp: update from rfc7829 Xin Long
2019-10-14 6:14 ` [PATCHv3 net-next 1/5] sctp: add SCTP_ADDR_POTENTIALLY_FAILED notification Xin Long
2019-10-18 15:56 ` David Laight
2019-10-19 8:55 ` Xin Long
2019-10-22 11:13 ` Xin Long
2019-10-25 3:22 ` Marcelo Ricardo Leitner
2019-10-25 7:58 ` Xin Long
2019-10-25 3:21 ` Marcelo Ricardo Leitner
2019-10-25 7:59 ` Xin Long
2019-10-14 6:14 ` [PATCHv3 net-next 2/5] sctp: add pf_expose per netns and sock and asoc Xin Long
2019-10-25 3:23 ` Marcelo Ricardo Leitner
2019-10-25 8:02 ` Xin Long
2019-10-25 9:00 ` David Laight [this message]
2019-10-25 13:21 ` 'Marcelo Ricardo Leitner'
2019-10-25 14:26 ` David Laight
2019-10-25 14:45 ` 'Marcelo Ricardo Leitner'
2019-10-14 6:14 ` [PATCHv3 net-next 3/5] sctp: add SCTP_EXPOSE_POTENTIALLY_FAILED_STATE sockopt Xin Long
2019-10-25 3:24 ` Marcelo Ricardo Leitner
2019-10-25 8:05 ` Xin Long
2019-10-14 6:14 ` [PATCHv3 net-next 4/5] sctp: add support for Primary Path Switchover Xin Long
2019-10-25 3:25 ` Marcelo Ricardo Leitner
2019-10-25 8:13 ` Xin Long
2019-10-14 6:14 ` [PATCHv3 net-next 5/5] sctp: add SCTP_PEER_ADDR_THLDS_V2 sockopt Xin Long
2019-10-14 12:42 ` [PATCHv3 net-next 0/5] sctp: update from rfc7829 Neil Horman
2019-10-16 0:56 ` David Miller
2019-10-16 10:42 ` David Laight
2019-10-17 4:56 ` Xin Long
2019-10-17 9:04 ` David Laight
2019-10-16 18:25 ` David Miller
2019-10-16 18:32 ` Marcelo Ricardo Leitner
2019-10-16 19:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=995e44322af74c41bbff2c77338f83bf@AcuMS.aculab.com \
--to=david.laight@aculab$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=linux-sctp@vger$(echo .)kernel.org \
--cc=lucien.xin@gmail$(echo .)com \
--cc=marcelo.leitner@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nhorman@tuxdriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox