From: Roopa Prabhu <roprabhu@cisco•com>
To: Sridhar Samudrala <sri@us•ibm.com>
Cc: "Michael S. Tsirkin" <mst@redhat•com>, <netdev@vger•kernel.org>,
<dragos.tatulea@gmail•com>, <arnd@arndb•de>, <dwang2@cisco•com>,
<benve@cisco•com>, <kaber@trash•net>, <davem@davemloft•net>,
<eric.dumazet@gmail•com>, <mchan@broadcom•com>,
<kvm@vger•kernel.org>
Subject: Re: [net-next-2.6 PATCH 0/3 RFC] macvlan: MAC Address filtering support for passthru mode
Date: Fri, 09 Sep 2011 09:21:51 -0700 [thread overview]
Message-ID: <CA8F8B2F.33CF2%roprabhu@cisco.com> (raw)
In-Reply-To: <4E699556.6050809@us.ibm.com>
On 9/8/11 9:25 PM, "Sridhar Samudrala" <sri@us•ibm.com> wrote:
> On 9/8/2011 8:00 PM, Roopa Prabhu wrote:
>>
>>
>> On 9/8/11 12:33 PM, "Michael S. Tsirkin"<mst@redhat•com> wrote:
>>
>>> On Thu, Sep 08, 2011 at 12:23:56PM -0700, Roopa Prabhu wrote:
>>>>> I think the main usecase for passthru mode is to assign a SR-IOV VF to
>>>>> a single guest.
>>>>>
>>>> Yes and for the passthru usecase this patch should be enough to enable
>>>> filtering in hw (eventually like I indicated before I need to fix vlan
>>>> filtering too).
>>> So with filtering in hw, and in sriov VF case, VFs
>>> actually share a filtering table. How will that
>>> be partitioned?
>> AFAIK, though it might maintain a single filter table space in hw, hw does
>> know which filter belongs to which VF. And the OS driver does not need to do
>> anything special. The VF driver exposes a VF netdev. And any uc/mc addresses
>> registered with a VF netdev are registered with the hw by the driver. And hw
>> will filter and send only pkts that the VF has expressed interest in.
> Does your NIC & driver support adding multiple mac addresses to a VF?
> I have tried a few other SR-IOV NICs sometime back and they didn't
> support this feature.
Yes our nic does. I thought Intel's also does (see ixgbevf_set_rx_mode).
Though I have not really tried using it on an Intel card. I think most cards
should at the least support multicast filters.
If the lower dev does not support unicast filtering, dev_uc_add(lowerdev,..)
puts the lower dev in promiscous mode. Though..i think I can chcek this
before hand in macvlan_open and put the lowerdev in promiscuous mode if it
does not support filtering.
>
> Currently, we don't have an interface to add multiple mac addresses to a
> netdev other than an
> indirect way of creating a macvlan /if on top of it.
Yes I think so. I have been using only macvlan to test.
Thanks,
Roopa
next prev parent reply other threads:[~2011-09-09 16:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 22:35 [net-next-2.6 PATCH 0/3 RFC] macvlan: MAC Address filtering support for passthru mode Roopa Prabhu
2011-09-06 22:35 ` [net-next-2.6 PATCH 1/3 RFC] macvlan: Add support for unicast filtering in macvlan Roopa Prabhu
2011-09-06 22:35 ` [net-next-2.6 PATCH 2/3 RFC] macvlan: Add function to set addr filters for device in passthru mode Roopa Prabhu
2011-09-06 22:35 ` [net-next-2.6 PATCH 3/3 RFC] macvtap: Add support for TUNSETTXFILTER Roopa Prabhu
2011-09-08 16:25 ` Arnd Bergmann
2011-09-08 19:06 ` Roopa Prabhu
2011-09-07 12:34 ` [net-next-2.6 PATCH 0/3 RFC] macvlan: MAC Address filtering support for passthru mode Michael S. Tsirkin
2011-09-08 5:20 ` Roopa Prabhu
2011-09-08 11:08 ` Michael S. Tsirkin
2011-09-08 16:19 ` Roopa Prabhu
2011-09-08 17:42 ` Sridhar Samudrala
2011-09-08 19:23 ` Roopa Prabhu
2011-09-08 19:33 ` Michael S. Tsirkin
2011-09-09 3:00 ` Roopa Prabhu
2011-09-09 4:25 ` Sridhar Samudrala
2011-09-09 16:21 ` Roopa Prabhu [this message]
2011-09-11 9:44 ` Michael S. Tsirkin
2011-09-11 13:18 ` Roopa Prabhu
2011-09-11 19:03 ` Michael S. Tsirkin
2011-09-12 17:02 ` Roopa Prabhu
2011-09-15 13:46 ` Roopa Prabhu
2011-09-26 23:06 ` Christian Benvenuti (benve)
2011-09-12 4:30 ` Sridhar Samudrala
2011-09-12 17:23 ` Roopa Prabhu
2011-09-08 19:11 ` Michael S. Tsirkin
2011-09-09 2:53 ` Roopa Prabhu
2011-09-09 5:55 ` Michael S. Tsirkin
2011-09-09 16:33 ` Roopa Prabhu
2011-09-11 9:38 ` Michael S. Tsirkin
2011-09-11 13:18 ` Roopa Prabhu
2011-09-11 18:52 ` Michael S. Tsirkin
2011-09-12 13:38 ` Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA8F8B2F.33CF2%roprabhu@cisco.com \
--to=roprabhu@cisco$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=benve@cisco$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dragos.tatulea@gmail$(echo .)com \
--cc=dwang2@cisco$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=kaber@trash$(echo .)net \
--cc=kvm@vger$(echo .)kernel.org \
--cc=mchan@broadcom$(echo .)com \
--cc=mst@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=sri@us$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox