Subject: Re: [PATCH net-next v3 04/19] net: enic: slight optimization of addr compare

From: "Sujith Sankar (ssujith)" <[email-masked]>
Date: Thu, 2 Jan 2014 04:09:34 +0000

Looks good.

Acked by: Sujith Sankar <[email-masked]>

On 30/12/13 1:42 PM, "Govindarajulu Varadarajan (gvaradar)"
<[email-masked]> wrote:

>On Mon, 30 Dec 2013, Ding Tianhong wrote:
>
>> Use possibly more efficient ether_addr_equal
>> to instead of memcmp.
>>
>> Cc: Christian Benvenuti <[email-masked]>
>> Cc: Sujith Sankar <[email-masked]>
>> Cc: Govindarajulu Varadarajan <[email-masked]>
>> Cc: Neel Patel <[email-masked]>
>> Cc: Nishank Trivedi <[email-masked]>
>> Signed-off-by: Ding Tianhong <[email-masked]>
>> ---
>> drivers/net/ethernet/cisco/enic/enic_pp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/cisco/enic/enic_pp.c
>>b/drivers/net/ethernet/cisco/enic/enic_pp.c
>> index 43464f0..e6a8319 100644
>> --- a/drivers/net/ethernet/cisco/enic/enic_pp.c
>> +++ b/drivers/net/ethernet/cisco/enic/enic_pp.c
>> @@ -162,7 +162,7 @@ static int enic_are_pp_different(struct
>>enic_port_profile *pp1,
>> 	return strcmp(pp1->name, pp2->name) | !!memcmp(pp1->instance_uuid,
>> 		pp2->instance_uuid, PORT_UUID_MAX) |
>> 		!!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) |
>> -		!!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN);
>> +		!ether_addr_equal(pp1->mac_addr, pp2->mac_addr);
>> }
>>
>> static int enic_pp_preassociate(struct enic *enic, int vf,
>> -- 
>> 1.8.0
>>
>
>looks good for me
>
>Acked-by: Govindarajulu Varadarajan <[email-masked]>