Subject: Re: [PATCH v3 net-next] tcp: Change txhash on every SYN and RTO retransmit

From: Lawrence Brakmo <[email-masked]>
Date: Wed, 28 Sep 2016 05:07:16 +0000

Neal and Yuchung, thank you for the feedback. I¹ve submitted v4 with your
recommended changes.

Thanks,
Larry

On 9/27/16, 6:28 PM, "Neal Cardwell" <[email-masked]> wrote:

>On Tue, Sep 27, 2016 at 8:18 PM, Yuchung Cheng <[email-masked]> wrote:
>> On Tue, Sep 27, 2016 at 4:31 PM, Lawrence Brakmo <[email-masked]> wrote:
>>> @@ -213,6 +215,8 @@ static int tcp_write_timeout(struct sock *sk)
>>>                         tcp_mtu_probing(icsk, sk);
>>>
>>>                         dst_negative_advice(sk);
>>> +               } else if (prandom_u32_max(100) <
>>>sysctl_tcp_rto_txhash_prob) {
>> The sysctl is not really needed but that's just my opinion.
>
>I agree that it sounds nice to simplify by not having a sysctl for
>this and always calling sk_rethink_txhash() here.
>
>neal