From: Lawrence Brakmo <brakmo@fb•com>
To: Stephen Hemminger <stephen@networkplumber•org>,
"davem@davemloft•net" <davem@davemloft•net>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
Stephen Hemminger <sthemmin@microsoft•com>
Subject: Re: [PATCH net-next 5/7] tcp_nv: make tcpnv_get_info static
Date: Tue, 10 Jan 2017 19:50:35 +0000 [thread overview]
Message-ID: <D49A76C3.24037%brakmo@fb.com> (raw)
In-Reply-To: <20170110181816.18991-6-sthemmin@microsoft.com>
On 1/10/17, 10:18 AM, "netdev-owner@vger•kernel.org on behalf of Stephen
Hemminger" <netdev-owner@vger•kernel.org on behalf of
stephen@networkplumber•org> wrote:
>Function only used in this file.
>
>Signed-off-by: Stephen Hemminger <sthemmin@microsoft•com>
>---
> net/ipv4/tcp_nv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/net/ipv4/tcp_nv.c b/net/ipv4/tcp_nv.c
>index 5de82a8d4d87..0065f44c40c1 100644
>--- a/net/ipv4/tcp_nv.c
>+++ b/net/ipv4/tcp_nv.c
>@@ -424,8 +424,8 @@ static void tcpnv_acked(struct sock *sk, const struct
>ack_sample *sample)
> }
>
> /* Extract info for Tcp socket info provided via netlink */
>-size_t tcpnv_get_info(struct sock *sk, u32 ext, int *attr,
>- union tcp_cc_info *info)
>+static size_t tcpnv_get_info(struct sock *sk, u32 ext, int *attr,
>+ union tcp_cc_info *info)
> {
> const struct tcpnv *ca = inet_csk_ca(sk);
>
>--
>2.11.0
>
You should also remove the line:
EXPORT_SYMBOL_GPL(tcpnv_get_info);
next prev parent reply other threads:[~2017-01-10 19:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 18:18 [PATCH net-next 0/7] warning related fixes Stephen Hemminger
2017-01-10 18:18 ` [PATCH net-next 1/7] flow_dissector: make local function static Stephen Hemminger
2017-01-10 18:32 ` David Miller
2017-01-10 18:43 ` Stephen Hemminger
2017-01-10 18:18 ` [PATCH net-next 2/7] vxlan: remove unused variable Stephen Hemminger
2017-01-10 18:18 ` [PATCH net-next 3/7] socket: make sockfs_setattr static Stephen Hemminger
2017-01-10 18:18 ` [PATCH net-next 4/7] dcb: validate netlink attribute link Stephen Hemminger
2017-01-10 18:18 ` [PATCH net-next 5/7] tcp_nv: make tcpnv_get_info static Stephen Hemminger
2017-01-10 19:50 ` Lawrence Brakmo [this message]
2017-01-10 18:18 ` [PATCH net-next 6/7] ipv6: make udpv6_queue_rcv_skb static Stephen Hemminger
2017-01-10 18:18 ` [PATCH net-next 7/7] fq_codel: fix set never used warning Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D49A76C3.24037%brakmo@fb.com \
--to=brakmo@fb$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
--cc=sthemmin@microsoft$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox