public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Ricardo B. Marlière" <rbm@suse•com>
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@oss•qualcomm.com>,
	"Fernando Fernandez Mancera" <fmancera@suse•de>,
	<netdev@vger•kernel.org>
Cc: "Ricardo B. Marlière" <rbm@suse•com>,
	"Krzysztof Kozlowski" <krzk@kernel•org>,
	"Geert Uytterhoeven" <geert@linux-m68k•org>,
	"Jason Gunthorpe" <jgg@ziepe•ca>,
	"Leon Romanovsky" <leon@kernel•org>,
	"Selvin Xavier" <selvin.xavier@broadcom•com>,
	"Andrew Lunn" <andrew+netdev@lunn•ch>,
	"David S. Miller" <davem@davemloft•net>,
	"Eric Dumazet" <edumazet@google•com>,
	"Jakub Kicinski" <kuba@kernel•org>,
	"Paolo Abeni" <pabeni@redhat•com>,
	"Ido Schimmel" <idosch@nvidia•com>,
	"Petr Machata" <petrm@nvidia•com>,
	"Simon Horman" <horms@kernel•org>,
	"Saurav Kashyap" <skashyap@marvell•com>,
	"Javed Hasan" <jhasan@marvell•com>,
	GR-QLogic-Storage-Upstream@marvell•com,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership•com>,
	"Martin K. Petersen" <martin.petersen@oracle•com>,
	"Nilesh Javali" <njavali@marvell•com>,
	"Manish Rangankar" <mrangankar@marvell•com>,
	"Varun Prakash" <varun@chelsio•com>,
	"Alexander Aring" <aahringo@redhat•com>,
	"David Teigland" <teigland@redhat•com>,
	"Andreas Gruenbacher" <agruenba@redhat•com>,
	"Nikolay Aleksandrov" <razor@blackwall•org>,
	"David Ahern" <dsahern@kernel•org>,
	"Pablo Neira Ayuso" <pablo@netfilter•org>,
	"Florian Westphal" <fw@strlen•de>, "Phil Sutter" <phil@nwl•cc>,
	"David Howells" <dhowells@redhat•com>,
	"Marc Dionne" <marc.dionne@auristor•com>,
	"Marcelo Ricardo Leitner" <marcelo.leitner@gmail•com>,
	"Xin Long" <lucien.xin@gmail•com>,
	"Jon Maloy" <jmaloy@redhat•com>,
	"Bjorn Andersson" <bjorn.andersson@oss•qualcomm.com>,
	"Arnd Bergmann" <arnd@arndb•de>,
	"Shawn Guo" <shawnguo@kernel•org>,
	"Eric Biggers" <ebiggers@kernel•org>,
	"Michal Simek" <michal.simek@amd•com>,
	"Luca Weiss" <luca.weiss@fairphone•com>,
	"Sven Peter" <sven@kernel•org>,
	"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp•renesas.com>,
	"Kuninori Morimoto" <kuninori.morimoto.gx@renesas•com>,
	"Andrew Morton" <akpm@linux-foundation•org>,
	"Kuan-Wei Chiu" <visitorckw@gmail•com>,
	"Herbert Xu" <herbert@gondor•apana.org.au>,
	"Ryota Sakamoto" <sakamo.ryota@gmail•com>,
	"Kuniyuki Iwashima" <kuniyu@google•com>,
	"Kir Chou" <note351@hotmail•com>,
	"David Gow" <david@davidgow•net>,
	"Vikas Gupta" <vikas.gupta@broadcom•com>,
	"Bhargava Marreddy" <bhargava.marreddy@broadcom•com>,
	"Rajashekar Hudumula" <rajashekar.hudumula@broadcom•com>,
	"Markus Blöchl" <markus@blochl•de>,
	linux-kernel@vger•kernel.org, linux-m68k@lists•linux-m68k.org,
	linux-rdma@vger•kernel.org, oss-drivers@corigine•com,
	linux-scsi@vger•kernel.org, gfs2@lists•linux.dev,
	bridge@lists•linux.dev, netfilter-devel@vger•kernel.org,
	coreteam@netfilter•org, linux-afs@lists•infradead.org,
	linux-sctp@vger•kernel.org,
	tipc-discussion@lists•sourceforge.net
Subject: Re: [PATCH 01/10 net-next v3] ipv6: convert CONFIG_IPV6 to built-in only and clean up Kconfigs
Date: Wed, 18 Mar 2026 06:50:51 -0300	[thread overview]
Message-ID: <DH5TCPI2CFJ2.ZBO1LQWYQUCO@suse.com> (raw)
In-Reply-To: <69dd007c-16d3-44c2-bc30-4e7f5a95addb@oss.qualcomm.com>

On Wed Mar 18, 2026 at 3:51 AM -03, Krzysztof Kozlowski wrote:
> On 17/03/2026 15:00, Fernando Fernandez Mancera wrote:
>> Maintaining a modular IPv6 stack offers image size savings for specific
>> setups, this benefit is outweighed by the architectural burden it
>> imposes on the subsystems on implementation and maintenance. Therefore,
>> drop it.
>> 
>> Change CONFIG_IPV6 from tristate to bool. Remove all Kconfig
>> dependencies across the tree that explicitly checked for IPV6=m. In
>> addition, remove MODULE_DESCRIPTION(), MODULE_ALIAS(), MODULE_AUTHOR()
>> and MODULE_LICENSE().
>> 
>> This is also replacing module_init() by device_initcall(). It is not
>> possible to use fs_initcall() as IPv4 does because that creates a race
>> condition on IPv6 addrconf.
>> 
>> Finally, modify the default configs from CONFIG_IPV6=m to CONFIG_IPV6=y
>> except for m68k as according to the bloat-o-meter the image is
>> increasing by 330KB~ and that isn't acceptable. Instead, disable IPv6 on
>> this architecture by default. This is aligned with m68k RAM requirements
>> and recommendations [1].
>> 
>> [1] http://www.linux-m68k.org/faq/ram.html
>> 
>> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse•de>
>> Tested-by: Ricardo B. Marlière <rbm@suse•com>
>
> That's a Kconfig/defconfig only patch, so build system. You cannot test
> it in a meaning of testing code. Building code is not testing.

Should I have sent 9 emails instead of 1 to the whole series?

>
>> Acked-by: Krzysztof Kozlowski <krzk@kernel•org>
>
> You removed important parts of Ack. It was not provided like that.
>
> Best regards,
> Krzysztof


  reply	other threads:[~2026-03-18  9:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 14:00 [PATCH 00/10 net-next v3] Convert CONFIG_IPV6 to built-in and remove stubs Fernando Fernandez Mancera
2026-03-17 14:00 ` [PATCH 01/10 net-next v3] ipv6: convert CONFIG_IPV6 to built-in only and clean up Kconfigs Fernando Fernandez Mancera
2026-03-18  6:51   ` Krzysztof Kozlowski
2026-03-18  9:50     ` Ricardo B. Marlière [this message]
2026-03-18 10:14     ` Fernando Fernandez Mancera
2026-03-18 10:17       ` Krzysztof Kozlowski
2026-03-17 14:00 ` [PATCH 02/10 net-next v3] ipv6: replace IS_BUILTIN(CONFIG_IPV6) with IS_ENABLED(CONFIG_IPV6) Fernando Fernandez Mancera
2026-03-17 14:00 ` [PATCH 03/10 net-next v3] ipv6: remove dynamic ICMPv6 sender registration infrastructure Fernando Fernandez Mancera
2026-03-17 14:01 ` [PATCH 04/10 net-next v3] ipv6: prepare headers for ipv6_stub removal Fernando Fernandez Mancera
2026-03-17 20:12   ` Ido Schimmel
2026-03-18 10:43     ` Fernando Fernandez Mancera
2026-03-18 12:45       ` Ido Schimmel
2026-03-18 13:01         ` Fernando Fernandez Mancera
2026-03-17 14:01 ` [PATCH 05/10 net-next v3] drivers: net: drop ipv6_stub usage and use direct function calls Fernando Fernandez Mancera
2026-03-17 14:01 ` [PATCH 06/10 net-next v3] ipv4: " Fernando Fernandez Mancera
2026-03-17 14:01 ` [PATCH 07/10 net-next v3] net: convert remaining ipv6_stub users to " Fernando Fernandez Mancera
2026-03-17 14:01 ` [PATCH 08/10 net-next v3] bpf: remove ipv6_bpf_stub completely and use " Fernando Fernandez Mancera
2026-03-17 14:01 ` [PATCH 09/10 net-next v3] ipv6: remove ipv6_stub infrastructure completely Fernando Fernandez Mancera
2026-03-17 14:01 ` [PATCH 10/10 net-next v3] netfilter: remove nf_ipv6_ops and use direct function calls Fernando Fernandez Mancera
2026-03-17 20:17   ` Ido Schimmel
2026-03-18 12:18     ` Fernando Fernandez Mancera
2026-03-17 19:49 ` [PATCH 00/10 net-next v3] Convert CONFIG_IPV6 to built-in and remove stubs Jakub Kicinski
2026-03-18 10:19   ` Fernando Fernandez Mancera
2026-03-18 23:21     ` Jakub Kicinski
2026-03-19  0:48       ` Jakub Kicinski
2026-03-19  8:28         ` Fernando Fernandez Mancera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DH5TCPI2CFJ2.ZBO1LQWYQUCO@suse.com \
    --to=rbm@suse$(echo .)com \
    --cc=GR-QLogic-Storage-Upstream@marvell$(echo .)com \
    --cc=James.Bottomley@HansenPartnership$(echo .)com \
    --cc=aahringo@redhat$(echo .)com \
    --cc=agruenba@redhat$(echo .)com \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=andrew+netdev@lunn$(echo .)ch \
    --cc=arnd@arndb$(echo .)de \
    --cc=bhargava.marreddy@broadcom$(echo .)com \
    --cc=bjorn.andersson@oss$(echo .)qualcomm.com \
    --cc=bridge@lists$(echo .)linux.dev \
    --cc=coreteam@netfilter$(echo .)org \
    --cc=davem@davemloft$(echo .)net \
    --cc=david@davidgow$(echo .)net \
    --cc=dhowells@redhat$(echo .)com \
    --cc=dsahern@kernel$(echo .)org \
    --cc=ebiggers@kernel$(echo .)org \
    --cc=edumazet@google$(echo .)com \
    --cc=fmancera@suse$(echo .)de \
    --cc=fw@strlen$(echo .)de \
    --cc=geert@linux-m68k$(echo .)org \
    --cc=gfs2@lists$(echo .)linux.dev \
    --cc=herbert@gondor$(echo .)apana.org.au \
    --cc=horms@kernel$(echo .)org \
    --cc=idosch@nvidia$(echo .)com \
    --cc=jgg@ziepe$(echo .)ca \
    --cc=jhasan@marvell$(echo .)com \
    --cc=jmaloy@redhat$(echo .)com \
    --cc=krzk@kernel$(echo .)org \
    --cc=krzysztof.kozlowski@oss$(echo .)qualcomm.com \
    --cc=kuba@kernel$(echo .)org \
    --cc=kuninori.morimoto.gx@renesas$(echo .)com \
    --cc=kuniyu@google$(echo .)com \
    --cc=leon@kernel$(echo .)org \
    --cc=linux-afs@lists$(echo .)infradead.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-m68k@lists$(echo .)linux-m68k.org \
    --cc=linux-rdma@vger$(echo .)kernel.org \
    --cc=linux-scsi@vger$(echo .)kernel.org \
    --cc=linux-sctp@vger$(echo .)kernel.org \
    --cc=luca.weiss@fairphone$(echo .)com \
    --cc=lucien.xin@gmail$(echo .)com \
    --cc=marc.dionne@auristor$(echo .)com \
    --cc=marcelo.leitner@gmail$(echo .)com \
    --cc=markus@blochl$(echo .)de \
    --cc=martin.petersen@oracle$(echo .)com \
    --cc=michal.simek@amd$(echo .)com \
    --cc=mrangankar@marvell$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=netfilter-devel@vger$(echo .)kernel.org \
    --cc=njavali@marvell$(echo .)com \
    --cc=note351@hotmail$(echo .)com \
    --cc=oss-drivers@corigine$(echo .)com \
    --cc=pabeni@redhat$(echo .)com \
    --cc=pablo@netfilter$(echo .)org \
    --cc=petrm@nvidia$(echo .)com \
    --cc=phil@nwl$(echo .)cc \
    --cc=prabhakar.mahadev-lad.rj@bp$(echo .)renesas.com \
    --cc=rajashekar.hudumula@broadcom$(echo .)com \
    --cc=razor@blackwall$(echo .)org \
    --cc=sakamo.ryota@gmail$(echo .)com \
    --cc=selvin.xavier@broadcom$(echo .)com \
    --cc=shawnguo@kernel$(echo .)org \
    --cc=skashyap@marvell$(echo .)com \
    --cc=sven@kernel$(echo .)org \
    --cc=teigland@redhat$(echo .)com \
    --cc=tipc-discussion@lists$(echo .)sourceforge.net \
    --cc=varun@chelsio$(echo .)com \
    --cc=vikas.gupta@broadcom$(echo .)com \
    --cc=visitorckw@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox