public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: janitor@sternwelten•at
To: netdev@oss•sgi.com
Cc: jgarzik@pobox•com, jt@hpl•hp.com, janitor@sternwelten•at
Subject: [patch 8/8]  prism54/islpci_dev: replace 	schedule_timeout() with msleep()
Date: Wed, 01 Sep 2004 23:06:01 +0200	[thread overview]
Message-ID: <E1C2cIs-00083w-5t@sputnik> (raw)







I would appreciate any comments from the janitor@sternweltens list. 



Description: Use msleep() instead of schedule_timeout() to guarantee
the task delays for the desired time.

Signed-off-by: Nishanth Aravamudan <nacc@us•ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten•at>



---

 linux-2.6.9-rc1-bk7-max/drivers/net/wireless/prism54/islpci_dev.c |    3 +--
 1 files changed, 1 insertion(+), 2 deletions(-)

diff -puN drivers/net/wireless/prism54/islpci_dev.c~msleep-drivers_net_wireless_prism54_islpci_dev drivers/net/wireless/prism54/islpci_dev.c
--- linux-2.6.9-rc1-bk7/drivers/net/wireless/prism54/islpci_dev.c~msleep-drivers_net_wireless_prism54_islpci_dev	2004-09-01 19:35:41.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/net/wireless/prism54/islpci_dev.c	2004-09-01 19:35:41.000000000 +0200
@@ -436,8 +436,7 @@ prism54_bring_down(islpci_private *priv)
 	wmb();
 
 	/* wait a while for the device to reset */
-	set_current_state(TASK_UNINTERRUPTIBLE);
-	schedule_timeout(50*HZ/1000);
+	msleep(50);
 
 	return 0;
 }

_

             reply	other threads:[~2004-09-01 21:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-01 21:06 janitor [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-09-02  6:50 [patch 8/8] prism54/islpci_dev: replace schedule_timeout() with msleep() Margit Schubert-While
2004-09-02  8:24 ` [Kernel-janitors] " maximilian attems
2004-09-02 16:09   ` Nishanth Aravamudan
2004-09-02  9:35 Margit Schubert-While
2004-09-02 10:03 ` maximilian attems
2004-09-02 10:21 Margit Schubert-While
2004-09-02 17:30 Margit Schubert-While
2004-09-02 17:52 Margit Schubert-While
2004-09-02 18:27 ` Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1C2cIs-00083w-5t@sputnik \
    --to=janitor@sternwelten$(echo .)at \
    --cc=jgarzik@pobox$(echo .)com \
    --cc=jt@hpl$(echo .)hp.com \
    --cc=netdev@oss$(echo .)sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox