From: Russell King <rmk+kernel@armlinux•org.uk>
To: Andrew Lunn <andrew@lunn•ch>, Heiner Kallweit <hkallweit1@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, Ioana Ciornei <ioana.ciornei@nxp•com>,
Jakub Kicinski <kuba@kernel•org>
Subject: [PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes
Date: Tue, 20 Jul 2021 10:57:43 +0100 [thread overview]
Message-ID: <E1m5mVT-00032g-Km@rmk-PC.armlinux.org.uk> (raw)
Phylink documentation says:
Note that the PHY may be able to transform from one connection
technology to another, so, eg, don't clear 1000BaseX just
because the MAC is unable to BaseX mode. This is more about
clearing unsupported speeds and duplex settings. The port modes
should not be cleared; phylink_set_port_modes() will help with this.
So add the missing 10G modes.
Signed-off-by: Russell King <rmk+kernel@armlinux•org.uk>
Acked-by: Marek Behún <kabel@kernel•org>
Acked-by: Ioana Ciornei <ioana.ciornei@nxp•com>
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
index ae6d382d8735..543c1f202420 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
@@ -140,6 +140,11 @@ static void dpaa2_mac_validate(struct phylink_config *config,
case PHY_INTERFACE_MODE_10GBASER:
case PHY_INTERFACE_MODE_USXGMII:
phylink_set(mask, 10000baseT_Full);
+ phylink_set(mask, 10000baseCR_Full);
+ phylink_set(mask, 10000baseSR_Full);
+ phylink_set(mask, 10000baseLR_Full);
+ phylink_set(mask, 10000baseLRM_Full);
+ phylink_set(mask, 10000baseER_Full);
if (state->interface == PHY_INTERFACE_MODE_10GBASER)
break;
phylink_set(mask, 5000baseT_Full);
--
2.20.1
next reply other threads:[~2021-07-20 9:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 9:57 Russell King [this message]
2021-07-20 13:51 ` [PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes Andrew Lunn
2021-07-20 14:11 ` Russell King (Oracle)
2021-07-20 14:13 ` Andrew Lunn
2021-08-16 14:47 ` Ioana Ciornei
2021-09-03 10:33 ` Russell King (Oracle)
2021-09-03 11:09 ` Ioana Ciornei
2021-09-03 11:34 ` Russell King (Oracle)
2021-09-03 13:11 ` Andrew Lunn
2021-09-03 17:06 ` Ioana Ciornei
2021-07-20 14:13 ` Andrew Lunn
-- strict thread matches above, loose matches on Subject: below --
2021-03-09 15:35 Russell King
2021-03-10 2:01 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1m5mVT-00032g-Km@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=hkallweit1@gmail$(echo .)com \
--cc=ioana.ciornei@nxp$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox