public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: "Eelco Chaudron" <echaudro@redhat•com>
To: "Stephen Hemminger" <stephen@networkplumber•org>
Cc: netdev@vger•kernel.org, davem@davemloft•net
Subject: Re: [PATCH iproute2/net-next] tc_util: Add support for showing TCA_STATS_BASIC_HW statistics
Date: Thu, 09 Aug 2018 18:56:32 +0200	[thread overview]
Message-ID: <FD2043FF-9EEC-4097-986E-C8393D3DF467@redhat.com> (raw)
In-Reply-To: <20180809090723.3caf4b3f@xeon-e3>

Thanks for the quick reply, see inline responses.

On 9 Aug 2018, at 18:07, Stephen Hemminger wrote:

> On Thu,  9 Aug 2018 11:16:02 -0400
> Eelco Chaudron <echaudro@redhat•com> wrote:
>
>>
>> +static void print_tcstats_basic_hw(struct rtattr **tbs, char 
>> *prefix)
>> +{
>> +	struct gnet_stats_basic bs = {0};
>
> If not present don't print it rather than printing zero.
>

This is used to print separate SW counters below, which is not displayed 
if 0, i.e. not present.
However I will move it under the “if (tbs[TCA_STATS_BASIC])” 
statement, so it’s more explicit.

>> +	struct gnet_stats_basic bs_hw = {0};
>
> This initialization is unnecessary since you always overwrite it.
>

Thanks will remove it in the v2

>> +
>> +	if (!tbs[TCA_STATS_BASIC_HW])
>> +		return;
>> +
>> +	memcpy(&bs_hw, RTA_DATA(tbs[TCA_STATS_BASIC_HW]),
>> +	       MIN(RTA_PAYLOAD(tbs[TCA_STATS_BASIC_HW]), sizeof(bs_hw)));
>> +
>> +	if (bs_hw.bytes == 0 && bs_hw.packets == 0)
>> +		return;
>> +
>> +	if (tbs[TCA_STATS_BASIC]) {
>> +		memcpy(&bs, RTA_DATA(tbs[TCA_STATS_BASIC]),
>> +		       MIN(RTA_PAYLOAD(tbs[TCA_STATS_BASIC]),
>> +			   sizeof(bs)));
>> +	}
>> +
>> +	if (bs.bytes >= bs_hw.bytes && bs.packets >= bs_hw.packets) {
>> +		print_string(PRINT_FP, NULL, "\n%s", prefix);
>
> Please use the magic string _SL_ to allow supporting single line 
> output mode.
>

Will do in the V2.

>> +		print_lluint(PRINT_ANY, "sw_bytes",
>> +			     "Sent software %llu bytes",
>> +			     bs.bytes - bs_hw.bytes);
>> +		print_uint(PRINT_ANY, "sw_packets", " %u pkt",
>> +			   bs.packets - bs_hw.packets);
>> +	}
>> +
>> +	print_string(PRINT_FP, NULL, "\n%s", prefix);
>> +	print_lluint(PRINT_ANY, "hw_bytes", "Sent hardware %llu bytes",
>> +		     bs_hw.bytes);
>> +	print_uint(PRINT_ANY, "hw_packets", " %u pkt", bs_hw.packets);
>> +}

     prev parent reply	other threads:[~2018-08-09 19:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09 15:16 [PATCH iproute2/net-next] tc_util: Add support for showing TCA_STATS_BASIC_HW statistics Eelco Chaudron
2018-08-09 16:07 ` Stephen Hemminger
2018-08-09 16:56   ` Eelco Chaudron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FD2043FF-9EEC-4097-986E-C8393D3DF467@redhat.com \
    --to=echaudro@redhat$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=stephen@networkplumber$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox