From: <emersonbernier@tutanota•com>
To: David Ahern <dsahern@gmail•com>
Cc: Michal Kubecek <mkubecek@suse•cz>,
Netdev <netdev@vger•kernel.org>,
Stephen <stephen@networkplumber•org>,
Kuznet <kuznet@ms2•inr.ac.ru>, Jason <jason@zx2c4•com>,
Davem <davem@davemloft•net>
Subject: Re: [BUG][iproute2][5.0] ip route show table default: "Error: ipv4: FIB table does not exist."
Date: Thu, 2 May 2019 15:17:55 +0200 (CEST) [thread overview]
Message-ID: <LdsgQO---3-1@tutanota.com> (raw)
In-Reply-To: <26689b18-e0f1-c490-7802-4256f12aa5e2@gmail.com>
Mar 24, 2019, 10:09 PM by dsahern@gmail•com:
> On 3/24/19 12:36 PM, Michal Kubecek wrote:
>
>> On Sun, Mar 24, 2019 at 07:29:08PM +0100, Michal Kubecek wrote:
>>
>>> On Sun, Mar 24, 2019 at 11:20:33AM -0600, David Ahern wrote:
>>>
>>>> On 3/24/19 11:02 AM, >>>> emersonbernier@tutanota•com <mailto:emersonbernier@tutanota•com>>>>> wrote:
>>>>
>>>>> Ok but previous versions of iproute2 didn't treat this as error and didn't exited with non-zero status. Is non existing default route a system error which needs fixing?
>>>>>
>>>>
>>>> The kernel is returning that error, not iproute2.
>>>>
>>>> It is the default *table*, not a default route.
>>>>
>>>
>>> Something did change on iproute2 side between 4.20 and 5.0, though:
>>>
>>> lion:~ # rpm -q iproute2
>>> iproute2-4.20-0.x86_64
>>> lion:~ # ip route show table default ; echo $?
>>> 0
>>> lion:~ # ip route show table 123 ; echo $?
>>> 0
>>> ...
>>> lion:~ # rpm -q iproute2
>>> iproute2-5.0.0-0.x86_64
>>> lion:~ # ip route show table default ; echo $?
>>> Error: ipv4: FIB table does not exist.
>>> Dump terminated
>>> 2
>>> lion:~ # ip route show table 123 ; echo $?
>>> Error: ipv4: FIB table does not exist.
>>> Dump terminated
>>> 2
>>>
>>> All I did was updating iproute2 package, the same kernel was running for
>>> both (I tried 5.0.3 and 5.1-rc1).
>>>
>>
>> Commit c7e6371bc4af ("ip route: Add protocol, table id and device to
>> dump request") seems to be an obvious candidate. Before it, no matching
>> rules in the dump used to be presented as an empty table but now ip gets
>> a kernel error which it displays to the user.
>>
>
> It's the commit that enables strict checking. Kernel side has been
> changed to better inform the user of what happens on a request when
> strict checking is enabled. iproute2 has been updated to use this.
>
> Essentially, ip asks for a dump of table 253. In the past there is no
> data, so nothing to return. The strict checking tells you explicitly
> "that table does not exist" versus the old method where nothing is
> returned and the user has to guess "the table exists but is empty or
> there is a bug dumping the table?"
>
> Given the legacy of table 253/default, iproute2 can easily catch this
> error and just do nothing for backwards compatibility.
>
Hi,
are those changes planned then? I don't see anything in repo
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/log/
next prev parent reply other threads:[~2019-05-02 13:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 13:00 [BUG][iproute2][5.0] ip route show table default: "Error: ipv4: FIB table does not exist." emersonbernier
2019-03-24 14:17 ` David Ahern
2019-03-24 17:02 ` emersonbernier
2019-03-24 17:20 ` David Ahern
2019-03-24 17:34 ` emersonbernier
2019-03-24 17:36 ` David Ahern
2019-03-24 18:29 ` Michal Kubecek
2019-03-24 18:36 ` Michal Kubecek
2019-03-24 22:09 ` David Ahern
2019-05-02 13:17 ` emersonbernier [this message]
2019-05-09 2:24 ` David Ahern
2019-05-17 10:22 ` 5.1 `ip route get addr/cidr` regression Jason A. Donenfeld
2019-05-17 14:17 ` Michal Kubecek
2019-05-17 15:20 ` David Ahern
2019-05-17 15:22 ` Jason A. Donenfeld
2019-05-17 15:17 ` David Ahern
2019-05-17 17:35 ` Stephen Hemminger
2019-05-17 17:39 ` David Ahern
2019-05-17 20:19 ` Jason A. Donenfeld
2019-05-17 20:30 ` Jason A. Donenfeld
2019-05-17 17:40 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=LdsgQO---3-1@tutanota.com \
--to=emersonbernier@tutanota$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@gmail$(echo .)com \
--cc=jason@zx2c4$(echo .)com \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=mkubecek@suse$(echo .)cz \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox