From: Saeed Mahameed <saeed@kernel•org>
To: Vadim Fedorenko <vadim.fedorenko@linux•dev>
Cc: Jakub Kicinski <kuba@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Paolo Abeni <pabeni@redhat•com>,
Eric Dumazet <edumazet@google•com>,
Saeed Mahameed <saeedm@nvidia•com>,
netdev@vger•kernel.org, Tariq Toukan <tariqt@nvidia•com>,
Rahul Rameshbabu <rrameshbabu@nvidia•com>
Subject: Re: [net 07/10] net/mlx5e: Correct SKB room check to use all room in the fifo
Date: Fri, 24 Feb 2023 10:03:51 -0800 [thread overview]
Message-ID: <Y/j8BzO2HQHZyopO@x130> (raw)
In-Reply-To: <28ccadd6-7c79-2a18-315e-3eabb14db80e@linux.dev>
On 24 Feb 12:18, Vadim Fedorenko wrote:
>On 24/02/2023 00:38, Jakub Kicinski wrote:
>>On Thu, 23 Feb 2023 14:52:44 -0800 Saeed Mahameed wrote:
>>>From: Rahul Rameshbabu <rrameshbabu@nvidia•com>
>>>
>>>Previous check was comparing against the fifo mask. The mask is size of the
>>>fifo (power of two) minus one, so a less than or equal comparator should be
>>>used for checking if the fifo has room for the SKB.
>>>
>>>Fixes: 19b43a432e3e ("net/mlx5e: Extend SKB room check to include PTP-SQ")
>>
>>How big is the fifo? Not utilizing a single entry is not really worth
>>calling a bug if the fifo has at least 32 entries..
>
>AFAIK, it has the same size that any other SQ queue, up to 8192
>entries for now.
I agree minimum size is 64, so not critical.
next prev parent reply other threads:[~2023-02-24 18:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 22:52 [pull request][net 00/10] mlx5 fixes 2023-02-23 Saeed Mahameed
2023-02-23 22:52 ` [net 01/10] net/mlx5: Remove NULL check before dev_{put, hold} Saeed Mahameed
2023-02-23 22:52 ` [net 02/10] net/mlx5e: TC, fix return value check in mlx5e_tc_act_stats_create() Saeed Mahameed
2023-02-23 22:52 ` [net 03/10] net/mlx5e: XDP, Allow growing tail for XDP multi buffer Saeed Mahameed
2023-02-24 0:34 ` Jakub Kicinski
2023-02-24 18:07 ` Saeed Mahameed
2023-04-08 11:24 ` Maxim Mikityanskiy
2023-02-23 22:52 ` [net 04/10] net/mlx5e: xsk: Set napi_id to support busy polling on XSK RQ Saeed Mahameed
2023-02-24 0:35 ` Jakub Kicinski
2023-02-23 22:52 ` [net 05/10] mlx5: fix skb leak while fifo resync and push Saeed Mahameed
2023-02-23 22:52 ` [net 06/10] mlx5: fix possible ptp queue fifo use-after-free Saeed Mahameed
2023-02-23 22:52 ` [net 07/10] net/mlx5e: Correct SKB room check to use all room in the fifo Saeed Mahameed
2023-02-24 0:38 ` Jakub Kicinski
2023-02-24 12:18 ` Vadim Fedorenko
2023-02-24 18:03 ` Saeed Mahameed [this message]
2023-02-24 21:58 ` David Laight
2023-02-23 22:52 ` [net 08/10] net/mlx5: ECPF, wait for VF pages only after disabling host PFs Saeed Mahameed
2023-02-23 22:52 ` [net 09/10] net/mlx5e: Verify flow_source cap before using it Saeed Mahameed
2023-02-23 22:52 ` [net 10/10] net/mlx5: Geneve, Fix handling of Geneve object id as error code Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/j8BzO2HQHZyopO@x130 \
--to=saeed@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rrameshbabu@nvidia$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox