From: Simon Horman <simon.horman@corigine•com>
To: Pedro Tammela <pctammela@mojatatu•com>
Cc: netdev@vger•kernel.org, jhs@mojatatu•com,
xiyou.wangcong@gmail•com, jiri@resnulli•us, davem@davemloft•net,
edumazet@google•com, kuba@kernel•org, pabeni@redhat•com,
amir@vadai•me, dcaratti@redhat•com, willemb@google•com,
ozsh@nvidia•com, paulb@nvidia•com
Subject: Re: [PATCH net 1/3] net/sched: act_pedit: fix action bind logic
Date: Sat, 25 Feb 2023 17:15:00 +0100 [thread overview]
Message-ID: <Y/o0BDsoepfkakiG@corigine.com> (raw)
In-Reply-To: <a15d21c6-8a88-6c9a-ca7e-77a31ecfbe28@mojatatu.com>
On Sat, Feb 25, 2023 at 10:38:31AM -0300, Pedro Tammela wrote:
> On 25/02/2023 10:08, Simon Horman wrote:
> > On Fri, Feb 24, 2023 at 12:00:56PM -0300, Pedro Tammela wrote:
> > > The TC architecture allows filters and actions to be created independently.
> > > In filters the user can reference action objects using:
> > > tc action add action pedit ... index 1
> > > tc filter add ... action pedit index 1
> > >
> > > In the current code for act_pedit this is broken as it checks netlink
> > > attributes for create/update before actually checking if we are binding to an
> > > existing action.
> > >
> > > tdc results:
> > > 1..69
> >
> > ...
> >
> > Hi Pedro,
> >
> > Thanks for running the tests :)
> >
> > I think this patch looks good - though I am still digesting it.
> > But I do wonder if you considered adding a test for this condition.
>
> Yes, they are in my backlog to post when net-next reopens.
Excellent, thanks.
> > Also, what is the failure mode?
>
> When referencing actions via its indexes on filters there would be three
> outcomes:
> 1 - Action binds to filter (expected)
> 2 - Action fails netlink parsing in kernel
> 3 - Action fails parsing in iproute2
>
> I also posted complementary iproute2 patches.
>
> >
> > If it is that user's can't bind actions to filters, but the kernel behaves
> > correctly with configurations it accepts. If so, then perhaps this is more
> > of a feature than a fix.
>
> I would argue it's a fix...
>
> > OTOH, perhaps it's a regression wrt the oldest of
> > the two patches references below.
>
> ...because filters and actions are completely separate TC objects.
> There shouldn't be actions that can be created independently but can't be
> really used.
I agree that shouldn't be the case.
For me that doesn't make it a bug, but I don't feel strongly about it.
In any case, I'm now happy with this patch.
Reviewed-by: Simon Horman <simon.horman@corigine•com>
...
next prev parent reply other threads:[~2023-02-25 16:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 15:00 [PATCH net 0/3] net/sched: fix action bind logic Pedro Tammela
2023-02-24 15:00 ` [PATCH net 1/3] net/sched: act_pedit: " Pedro Tammela
2023-02-25 13:08 ` Simon Horman
2023-02-25 13:38 ` Pedro Tammela
2023-02-25 16:15 ` Simon Horman [this message]
2023-02-27 19:36 ` Jakub Kicinski
2023-02-27 19:51 ` Jamal Hadi Salim
2023-02-27 20:04 ` Jakub Kicinski
2023-02-27 21:41 ` Jakub Kicinski
2023-02-27 21:47 ` Jamal Hadi Salim
2023-02-24 15:00 ` [PATCH net 2/3] net/sched: act_mpls: " Pedro Tammela
2023-02-25 16:17 ` Simon Horman
2023-02-24 15:00 ` [PATCH net 3/3] net/sched: act_sample: " Pedro Tammela
2023-02-25 16:20 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/o0BDsoepfkakiG@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=amir@vadai$(echo .)me \
--cc=davem@davemloft$(echo .)net \
--cc=dcaratti@redhat$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ozsh@nvidia$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=paulb@nvidia$(echo .)com \
--cc=pctammela@mojatatu$(echo .)com \
--cc=willemb@google$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox