Subject: Re: [PATCH net v2] net/sched: act_connmark: handle errno on tcf_idr_check_alloc

From: Simon Horman <[email-masked]>
Date: Mon, 27 Feb 2023 16:56:30 +0100

On Mon, Feb 27, 2023 at 12:23:52PM -0300, Pedro Tammela wrote:
> Smatch reports that 'ci' can be used uninitialized.
> The current code ignores errno coming from tcf_idr_check_alloc, which
> will lead to the incorrect usage of 'ci'. Handle the errno as it should.
> 
> Fixes: 288864effe33 ("net/sched: act_connmark: transition to percpu stats and rcu")
> Reviewed-by: Jamal Hadi Salim <[email-masked]>
> Signed-off-by: Pedro Tammela <[email-masked]>

Thanks Pedro,

looks good to me.

Reviewed-by: Simon Horman <[email-masked]>