From: Borislav Petkov <bp@alien8•de>
To: "Michael Kelley (LINUX)" <mikelley@microsoft•com>
Cc: Sean Christopherson <seanjc@google•com>,
Dave Hansen <dave.hansen@intel•com>,
"hpa@zytor•com" <hpa@zytor•com>,
KY Srinivasan <kys@microsoft•com>,
Haiyang Zhang <haiyangz@microsoft•com>,
"wei.liu@kernel•org" <wei.liu@kernel•org>,
Dexuan Cui <decui@microsoft•com>,
"luto@kernel•org" <luto@kernel•org>,
"peterz@infradead•org" <peterz@infradead•org>,
"davem@davemloft•net" <davem@davemloft•net>,
"edumazet@google•com" <edumazet@google•com>,
"kuba@kernel•org" <kuba@kernel•org>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"lpieralisi@kernel•org" <lpieralisi@kernel•org>,
"robh@kernel•org" <robh@kernel•org>,
"kw@linux•com" <kw@linux•com>,
"bhelgaas@google•com" <bhelgaas@google•com>,
"arnd@arndb•de" <arnd@arndb•de>, "hch@lst•de" <hch@lst•de>,
"m.szyprowski@samsung•com" <m.szyprowski@samsung•com>,
"robin.murphy@arm•com" <robin.murphy@arm•com>,
"thomas.lendacky@amd•com" <thomas.lendacky@amd•com>,
"brijesh.singh@amd•com" <brijesh.singh@amd•com>,
"tglx@linutronix•de" <tglx@linutronix•de>,
"mingo@redhat•com" <mingo@redhat•com>,
"dave.hansen@linux•intel.com" <dave.hansen@linux•intel.com>,
Tianyu Lan <Tianyu.Lan@microsoft•com>,
"kirill.shutemov@linux•intel.com"
<kirill.shutemov@linux•intel.com>,
"sathyanarayanan.kuppuswamy@linux•intel.com"
<sathyanarayanan.kuppuswamy@linux•intel.com>,
"ak@linux•intel.com" <ak@linux•intel.com>,
"isaku.yamahata@intel•com" <isaku.yamahata@intel•com>,
"dan.j.williams@intel•com" <dan.j.williams@intel•com>,
"jane.chu@oracle•com" <jane.chu@oracle•com>,
"tony.luck@intel•com" <tony.luck@intel•com>,
"x86@kernel•org" <x86@kernel•org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-hyperv@vger•kernel.org" <linux-hyperv@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linux-pci@vger•kernel.org" <linux-pci@vger•kernel.org>,
"linux-arch@vger•kernel.org" <linux-arch@vger•kernel.org>,
"iommu@lists•linux.dev" <iommu@lists•linux.dev>
Subject: Re: [PATCH v5 06/14] x86/ioremap: Support hypervisor specified range to map as encrypted
Date: Thu, 16 Feb 2023 18:06:34 +0100 [thread overview]
Message-ID: <Y+5immKTXCsjSysx@zn.tnic> (raw)
In-Reply-To: <BYAPR21MB168853FD0676CCACF7C249B0D7A09@BYAPR21MB1688.namprd21.prod.outlook.com>
On Thu, Feb 16, 2023 at 04:16:16PM +0000, Michael Kelley (LINUX) wrote:
> Historically, callbacks like Sean proposed default to NULL and do nothing
> unless they are explicitly set. The Hyper-V vTOM code would set the callback.
> Is that not sufficient? Or in the two places where the callback would
> be made, do you want to bracket with a test for being in a Hyper-V vTOM
> VM? If so, then we're back to needing something like CC_ATTR_PARAVISOR
> on which to gate the callbacks.
>
> Or do you mean something else entirely?
See the second part of my reply.
This thing...
> > because there's the next crapola with
> >
> > https://lore.kernel.org/all/20230209072220.6836-4-jgross@suse.com/
> >
> > because apparently hyperv does PAT but disables MTRRs for such vTOM
> > SEV-SNP guests and ... madness.
> >
> > But that's not the only example - Xen has been doing this thing too.
> >
> > And Jürgen has been trying to address this in a clean way but it is
> > a pain.
> >
> > What I don't want to have is a gazillion ways to check what needs to
> > happen for which guest type. Because people who change the kernel to run
> > on baremetal, will break them. And I can't blame them. We try to support
> > all kinds of guests in the x86 code but this support should be plain and
> > simple.
... here.
We need a single way to test for this guest type and stick with it.
I'd like for all guest types we support to be queried in a plain and
simple way.
Not:
* CC_ATTR_GUEST_MEM_ENCRYPT
* x86_platform.hyper.is_private_mmio(addr)
* CC_ATTR_PARAVISOR
to mean three different aspects of SEV-SNP guests using vTOM on Hyper-V.
This is going to be a major mess which we won't support.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-02-16 17:06 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 21:42 [PATCH v5 00/14] Add PCI pass-thru support to Hyper-V Confidential VMs Michael Kelley
2023-01-12 21:42 ` [PATCH v5 01/14] x86/ioapic: Gate decrypted mapping on cc_platform_has() attribute Michael Kelley
2023-01-12 21:42 ` [PATCH v5 02/14] x86/hyperv: Reorder code to facilitate future work Michael Kelley
2023-01-12 21:42 ` [PATCH v5 03/14] Drivers: hv: Explicitly request decrypted in vmap_pfn() calls Michael Kelley
2023-01-12 21:42 ` [PATCH v5 04/14] x86/mm: Handle decryption/re-encryption of bss_decrypted consistently Michael Kelley
2023-01-12 21:42 ` [PATCH v5 05/14] init: Call mem_encrypt_init() after Hyper-V hypercall init is done Michael Kelley
2023-01-12 21:42 ` [PATCH v5 06/14] x86/ioremap: Support hypervisor specified range to map as encrypted Michael Kelley
2023-01-20 20:15 ` Borislav Petkov
2023-01-21 4:10 ` Michael Kelley (LINUX)
2023-01-25 14:55 ` Borislav Petkov
2023-02-02 5:49 ` Michael Kelley (LINUX)
2023-02-07 12:41 ` Borislav Petkov
2023-02-07 19:01 ` Michael Kelley (LINUX)
2023-02-07 19:33 ` Borislav Petkov
2023-02-07 19:48 ` Michael Kelley (LINUX)
2023-02-07 19:54 ` Borislav Petkov
2023-02-07 19:57 ` Michael Kelley (LINUX)
2023-02-08 0:18 ` Michael Kelley (LINUX)
2023-02-08 15:09 ` Dave Hansen
2023-02-09 17:29 ` Michael Kelley (LINUX)
2023-02-08 17:23 ` Dave Hansen
2023-02-09 17:47 ` Michael Kelley (LINUX)
2023-02-10 18:41 ` Sean Christopherson
2023-02-10 18:58 ` Dave Hansen
2023-02-10 19:03 ` Borislav Petkov
2023-02-10 19:15 ` Michael Kelley (LINUX)
2023-02-10 19:36 ` Borislav Petkov
2023-02-10 19:58 ` Dave Hansen
2023-02-10 20:50 ` Sean Christopherson
2023-02-10 20:57 ` Sean Christopherson
2023-02-10 21:27 ` Michael Kelley (LINUX)
2023-02-10 23:47 ` Sean Christopherson
2023-02-14 7:45 ` Michael Kelley (LINUX)
2023-02-16 13:32 ` Borislav Petkov
2023-02-16 16:16 ` Michael Kelley (LINUX)
2023-02-16 17:06 ` Borislav Petkov [this message]
2023-02-17 6:16 ` Michael Kelley (LINUX)
2023-02-17 14:55 ` Borislav Petkov
2023-02-22 22:13 ` Sean Christopherson
2023-02-22 22:33 ` Borislav Petkov
2023-02-22 22:54 ` Sean Christopherson
2023-02-22 23:34 ` Borislav Petkov
2023-02-23 1:21 ` Sean Christopherson
2023-02-23 10:45 ` Borislav Petkov
2023-02-23 20:01 ` Michael Kelley (LINUX)
2023-02-23 20:27 ` Dave Hansen
2023-03-06 21:51 ` Borislav Petkov
2023-03-09 11:12 ` David Woodhouse
2023-03-09 11:59 ` Borislav Petkov
2023-03-09 13:00 ` David Woodhouse
2023-03-09 14:19 ` Tom Lendacky
2023-03-09 14:36 ` Jörg Rödel
2023-03-09 14:45 ` Borislav Petkov
2023-03-09 15:45 ` David Woodhouse
2023-03-09 16:34 ` Borislav Petkov
2023-03-10 10:05 ` David Woodhouse
2023-02-23 20:26 ` Dave Hansen
2023-02-23 20:41 ` Dave Hansen
2023-02-23 20:51 ` Michael Kelley (LINUX)
2023-02-23 21:07 ` Sean Christopherson
2023-02-23 21:15 ` Michael Kelley (LINUX)
2023-02-23 21:24 ` Dave Hansen
2023-01-12 21:42 ` [PATCH v5 07/14] x86/hyperv: Change vTOM handling to use standard coco mechanisms Michael Kelley
2023-01-12 21:42 ` [PATCH v5 08/14] swiotlb: Remove bounce buffer remapping for Hyper-V Michael Kelley
2023-01-12 21:42 ` [PATCH v5 09/14] Drivers: hv: vmbus: Remove second mapping of VMBus monitor pages Michael Kelley
2023-01-12 21:42 ` [PATCH v5 10/14] Drivers: hv: vmbus: Remove second way of mapping ring buffers Michael Kelley
2023-01-12 21:42 ` [PATCH v5 11/14] hv_netvsc: Remove second mapping of send and recv buffers Michael Kelley
2023-01-12 21:42 ` [PATCH v5 12/14] Drivers: hv: Don't remap addresses that are above shared_gpa_boundary Michael Kelley
2023-01-12 21:42 ` [PATCH v5 13/14] PCI: hv: Add hypercalls to read/write MMIO space Michael Kelley
2023-01-12 21:42 ` [PATCH v5 14/14] PCI: hv: Enable PCI pass-thru devices in Confidential VMs Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+5immKTXCsjSysx@zn.tnic \
--to=bp@alien8$(echo .)de \
--cc=Tianyu.Lan@microsoft$(echo .)com \
--cc=ak@linux$(echo .)intel.com \
--cc=arnd@arndb$(echo .)de \
--cc=bhelgaas@google$(echo .)com \
--cc=brijesh.singh@amd$(echo .)com \
--cc=dan.j.williams@intel$(echo .)com \
--cc=dave.hansen@intel$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=decui@microsoft$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=haiyangz@microsoft$(echo .)com \
--cc=hch@lst$(echo .)de \
--cc=hpa@zytor$(echo .)com \
--cc=iommu@lists$(echo .)linux.dev \
--cc=isaku.yamahata@intel$(echo .)com \
--cc=jane.chu@oracle$(echo .)com \
--cc=kirill.shutemov@linux$(echo .)intel.com \
--cc=kuba@kernel$(echo .)org \
--cc=kw@linux$(echo .)com \
--cc=kys@microsoft$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-hyperv@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=lpieralisi@kernel$(echo .)org \
--cc=luto@kernel$(echo .)org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=mikelley@microsoft$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=robh@kernel$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=sathyanarayanan.kuppuswamy@linux$(echo .)intel.com \
--cc=seanjc@google$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thomas.lendacky@amd$(echo .)com \
--cc=tony.luck@intel$(echo .)com \
--cc=wei.liu@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox