From: Simon Horman <simon.horman@corigine•com>
To: Jiri Pirko <jiri@resnulli•us>
Cc: Leon Romanovsky <leon@kernel•org>,
Jakub Kicinski <kuba@kernel•org>,
David Miller <davem@davemloft•net>,
Paolo Abeni <pabeni@redhat•com>,
Michael Chan <michael.chan@broadcom•com>,
Andy Gospodarek <andy@greyhouse•net>,
Gal Pressman <gal@nvidia•com>, Saeed Mahameed <saeed@kernel•org>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
Edward Cree <ecree.xilinx@gmail•com>,
Vladimir Oltean <vladimir.oltean@nxp•com>,
Andrew Lunn <andrew@lunn•ch>, Fei Qin <fei.qin@corigine•com>,
netdev@vger•kernel.org, oss-drivers@corigine•com
Subject: Re: [PATCH/RFC net-next 1/2] devlink: expose port function commands to assign VFs to multiple netdevs
Date: Wed, 8 Feb 2023 13:09:18 +0100 [thread overview]
Message-ID: <Y+OQ7mnoRux2VGdD@corigine.com> (raw)
In-Reply-To: <Y+OKeVE9jaoL4qhf@nanopsycho>
On Wed, Feb 08, 2023 at 12:41:45PM +0100, Jiri Pirko wrote:
> Wed, Feb 08, 2023 at 12:36:53PM CET, simon.horman@corigine•com wrote:
> >On Wed, Feb 08, 2023 at 01:21:22PM +0200, Leon Romanovsky wrote:
> >> On Mon, Feb 06, 2023 at 06:42:27PM -0800, Jakub Kicinski wrote:
> >> > On Mon, 6 Feb 2023 16:36:02 +0100 Simon Horman wrote:
> >> > > +VF assignment setup
> >> > > +---------------------------
> >> > > +In some cases, NICs could have multiple physical ports per PF. Users can assign VFs to
> >> > > +different ports.
> >> >
> >> > Please make sure you run make htmldocs when changing docs,
> >> > this will warn.
> >> >
> >> > > +- Get count of VFs assigned to physical port::
> >> > > +
> >> > > + $ devlink port show pci/0000:82:00.0/0
> >> > > + pci/0000:82:00.0/0: type eth netdev enp130s0np0 flavour physical port 0 splittable true lanes 4
> >> >
> >> > Physical port has VFs? My knee jerk reaction is that allocating
> >> > resources via devlink is fine but this seems to lean a bit into
> >> > forwarding. How do other vendors do it? What's the mapping of VFs
> >> > to ports?
> >>
> >> I don't understand the meaning of VFs here. If we are talking about PCI
> >> VFs, other vendors follow PCI spec "9.3.3.3.1 VF Enable" section, which
> >> talks about having one bit to enable all VFs at once. All these VFs will
> >> have separate netdevs.
> >
> >Yes, that is the case here too (before and after).
> >
> >What we are talking about is the association of VFs to physical ports
> >(in the case where a NIC has more than one physical port).
>
> What is "the association"?
My current explanation - and I'm sure I can dig and find others - is
to association == plugged into same VEB. But I feel that description
will lead to further confusion :(
next prev parent reply other threads:[~2023-02-08 12:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 15:36 [PATCH/RFC net-next 0/2] devlink: expose port function commands to assign VFs to multiple devlink Simon Horman
2023-02-06 15:36 ` [PATCH/RFC net-next 1/2] devlink: expose port function commands to assign VFs to multiple netdevs Simon Horman
2023-02-07 2:42 ` Jakub Kicinski
2023-02-08 10:38 ` Simon Horman
2023-02-08 11:21 ` Leon Romanovsky
2023-02-08 11:36 ` Simon Horman
2023-02-08 11:41 ` Jiri Pirko
2023-02-08 12:09 ` Simon Horman [this message]
2023-02-08 11:53 ` Leon Romanovsky
2023-02-08 12:05 ` Simon Horman
2023-02-08 21:37 ` Saeed Mahameed
2023-02-08 23:35 ` Jakub Kicinski
2023-02-09 0:55 ` Saeed Mahameed
2023-02-09 2:20 ` Yinjun Zhang
2023-02-09 15:15 ` Jiri Pirko
2023-02-10 2:14 ` Yinjun Zhang
2023-02-10 3:30 ` Jakub Kicinski
2023-02-10 9:45 ` Jiri Pirko
2023-02-08 11:40 ` Jiri Pirko
2023-02-08 12:07 ` Simon Horman
2023-02-08 12:34 ` Jiri Pirko
2023-02-08 12:37 ` Simon Horman
2023-02-08 23:41 ` Jakub Kicinski
2023-02-06 15:36 ` [PATCH/RFC net-next 2/2] nfp: add support for assigning VFs to different physical ports Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+OQ7mnoRux2VGdD@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=andy@greyhouse$(echo .)net \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ecree.xilinx@gmail$(echo .)com \
--cc=fei.qin@corigine$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@corigine$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=saeed@kernel$(echo .)org \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox