From: Willy Tarreau <w@1wt•eu>
To: Greg KH <gregkh@linuxfoundation•org>
Cc: Winter <winter@winter•cafe>,
stable@vger•kernel.org, regressions@lists•linux.dev,
netdev@vger•kernel.org
Subject: Re: [REGRESSION] 5.15.88 and onwards no longer return EADDRINUSE from bind
Date: Mon, 13 Feb 2023 08:52:34 +0100 [thread overview]
Message-ID: <Y+nsQlVzmTP0meTX@1wt.eu> (raw)
In-Reply-To: <Y+nl7nzQ3GPxlztq@kroah.com>
Hi Greg,
On Mon, Feb 13, 2023 at 08:25:34AM +0100, Greg KH wrote:
> On Mon, Feb 13, 2023 at 05:27:03AM +0100, Willy Tarreau wrote:
> > Hi,
> >
> > [CCed netdev]
> >
> > On Sun, Feb 12, 2023 at 10:38:40PM -0500, Winter wrote:
> > > Hi all,
> > >
> > > I'm facing the same issue as
> > > https://lore.kernel.org/stable/CAFsF8vL4CGFzWMb38_XviiEgxoKX0GYup=JiUFXUOmagdk9CRg@mail.gmail.com/,
> > > but on 5.15. I've bisected it across releases to 5.15.88, and can reproduce
> > > on 5.15.93.
> > >
> > > However, I cannot seem to find the identified problematic commit in the 5.15
> > > branch, so I'm unsure if this is a different issue or not.
> > >
> > > There's a few ways to reproduce this issue, but the one I've been using is
> > > running libuv's (https://github.com/libuv/libuv) tests, specifically tests
> > > 271 and 277.
> >
> > >From the linked patch:
> >
> > https://lore.kernel.org/stable/20221228144337.512799851@linuxfoundation.org/
>
> But that commit only ended up in 6.0.y, not 5.15, so how is this an
> issue in 5.15.y?
Hmmm I plead -ENOCOFFEE on my side, I hadn't notice the "can't find the
problematic commit", you're right indeed.
However if the issue happened in 5.15.88, the only part touching the
network listening area is this one which may introduce an EINVAL on
one listening path, but that seems unrelated to me given that it's
only for ULP that libuv doesn't seem to be using:
dadd0dcaa67d ("net/ulp: prevent ULP without clone op from entering the LISTEN status")
I guess the reporter will need to further bisect the problem to figure
the exact patch at this point.
Willy
next prev parent reply other threads:[~2023-02-13 7:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <EF8A45D0-768A-4CD5-9A8A-0FA6E610ABF7@winter.cafe>
2023-02-13 4:27 ` [REGRESSION] 5.15.88 and onwards no longer return EADDRINUSE from bind Willy Tarreau
2023-02-13 7:25 ` Greg KH
2023-02-13 7:52 ` Willy Tarreau [this message]
2023-02-13 16:44 ` Kuniyuki Iwashima
2023-02-13 17:48 ` Greg KH
2023-02-13 20:58 ` Kuniyuki Iwashima
2023-02-17 14:22 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+nsQlVzmTP0meTX@1wt.eu \
--to=w@1wt$(echo .)eu \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=regressions@lists$(echo .)linux.dev \
--cc=stable@vger$(echo .)kernel.org \
--cc=winter@winter$(echo .)cafe \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox