Subject: Re: [RFC PATCH v3 6/6] ptp_ocp: implement DPLL ops

From: Jiri Pirko <[email-masked]>
Date: Wed, 12 Oct 2022 17:14:46 +0200

Mon, Oct 10, 2022 at 03:18:04AM CEST, [email-masked] wrote:
>From: Vadim Fedorenko <[email-masked]>

[...]

>+static int ptp_ocp_dpll_get_status(struct dpll_device *dpll)
>+{
>+	struct ptp_ocp *bp = (struct ptp_ocp *)dpll_priv(dpll);

Avoid cast from (void *), not needed. (I also mentioned this in RFCv2).

>+	int sync;
>+
>+	sync = ioread32(&bp->reg->status) & OCP_STATUS_IN_SYNC;
>+	return sync;
>+}
>+

[...]