From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Maxime Chevallier <maxime.chevallier@bootlin•com>
Cc: Sean Anderson <seanga2@gmail•com>,
davem@davemloft•net, Rob Herring <robh+dt@kernel•org>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
thomas.petazzoni@bootlin•com, Andrew Lunn <andrew@lunn•ch>,
Jakub Kicinski <kuba@kernel•org>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Heiner Kallweit <hkallweit1@gmail•com>,
linux-arm-kernel@lists•infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro•org>,
devicetree@vger•kernel.org
Subject: Re: [PATCH net-next v3 3/5] net: pcs: add new PCS driver for altera TSE PCS
Date: Wed, 26 Oct 2022 13:47:52 +0100 [thread overview]
Message-ID: <Y1kseONzzimgWQP3@shell.armlinux.org.uk> (raw)
In-Reply-To: <20221026113711.2b740c7a@pc-8.home>
On Wed, Oct 26, 2022 at 11:37:11AM +0200, Maxime Chevallier wrote:
> Hello Sean,
>
> On Sun, 9 Oct 2022 01:38:15 -0400
> Sean Anderson <seanga2@gmail•com> wrote:
>
>
> > > +#define SGMII_PCS_LINK_TIMER_REG(x) (0x12 + (x))
> >
> > Not used.
>
> Right, I'll remove that in a followup patch
>
> > > +#define SGMII_PCS_LINK_TIMER_1 0x13
> > > +#define SGMII_PCS_IF_MODE 0x14
> > > +#define PCS_IF_MODE_SGMII_ENA BIT(0)
> > > +#define PCS_IF_MODE_USE_SGMII_AN BIT(1)
> > > +#define PCS_IF_MODE_SGMI_SPEED_MASK GENMASK(3, 2)
> > > +#define PCS_IF_MODE_SGMI_SPEED_10 (0 << 2)
> > > +#define PCS_IF_MODE_SGMI_SPEED_100 (1 << 2)
> > > +#define PCS_IF_MODE_SGMI_SPEED_1000 (2 << 2)
> >
> > You can use FIELD_PREP if you're so inclined. I assume SGMI is from
> > the datasheet.
>
> Will do ! thanks :)
>
> > > +#define PCS_IF_MODE_SGMI_HALF_DUPLEX BIT(4)
> > > +#define PCS_IF_MODE_SGMI_PHY_ANi BIT(5)
The definitions up to here look very similar to pcs-lynx.c when it comes
to 1000base-X and SGMII. I wonder whether regmap can help here to
abstract the register access differences and then maybe code can be
shared.
What value is in registers 2 and 3 (the ID registers) for this PCS?
On the link timer value setting, I have a patch to add a phylink helper
which returns the link timer in nanoseconds. May be a good idea if we
get that queued up so drivers can make use of it rather than hard-coding
a register value everywhere.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-10-26 12:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 14:35 [PATCH net-next v3 0/5] net: altera: tse: phylink conversion Maxime Chevallier
2022-09-01 14:35 ` [PATCH net-next v3 1/5] dt-bindings: net: Convert Altera TSE bindings to yaml Maxime Chevallier
2022-09-01 14:35 ` [PATCH net-next v3 2/5] net: altera: tse: cosmetic change to use reverse xmas tree ordering Maxime Chevallier
2022-09-01 14:35 ` [PATCH net-next v3 3/5] net: pcs: add new PCS driver for altera TSE PCS Maxime Chevallier
2022-10-09 5:38 ` Sean Anderson
2022-10-26 9:37 ` Maxime Chevallier
2022-10-26 12:05 ` Andrew Lunn
2022-10-26 12:47 ` Russell King (Oracle) [this message]
2022-09-01 14:35 ` [PATCH net-next v3 4/5] net: altera: tse: convert to phylink Maxime Chevallier
2022-09-02 4:10 ` Jakub Kicinski
2022-09-02 7:57 ` Maxime Chevallier
2022-09-01 14:35 ` [PATCH net-next v3 5/5] dt-bindings: net: altera: tse: add an optional pcs register range Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1kseONzzimgWQP3@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=krzysztof.kozlowski@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=seanga2@gmail$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox