Subject: Re: [External] : Re: [PATCH 1/1] IB/mlx5: Add a signature check to received EQEs and CQEs

From: Leon Romanovsky <[email-masked]>
Date: Thu, 27 Oct 2022 15:23:20 +0300

On Tue, Oct 25, 2022 at 10:44:12AM -0700, Rohit Nair wrote:
> Hey Leon,
> 
> Please find my replies to your comments here below:

<...>

> > 
> > > This patch does not introduce any significant performance degradations
> > > and has been tested using qperf.
> > What does it mean? You made changes in kernel verbs flow, they are not
> > executed through qperf.
> We also conducted several extensive performance tests using our test-suite
> which utilizes rds-stress and also saw no significant performance
> degrdations in those results.

What does it mean "also"? Your change is applicable ONLY for kernel path.

Anyway, I'm not keen adding rare debug code to performance critical path.

Thanks