Subject: Re: [PATCH 01/15] hamradio: baycom: remove BAYCOM_MAGIC

From: Dan Carpenter <[email-masked]>
Date: Fri, 28 Oct 2022 17:07:02 +0300

On Fri, Oct 28, 2022 at 08:50:59PM +0700, Bagas Sanjaya wrote:
> On 10/28/22 20:43, Dan Carpenter wrote:
> >>
> >> Also, s/Kill it/Remove BAYCOM_MAGIC from magic numbers table/ (your
> >> wording is kinda mature).
> >>
> > 
> > The kernel has almost 13 thousand kills...
> > 
> > $ git grep -i kill | wc -l
> > 12975
> > $
> > 
> > It's fine.
> > 
> 
> The word meaning depends on context. In this case, the author means
> removing SOME_MAGIC magic number from the table, one by one until
> the magic number documentation is removed (due to historical cruft).

Kernel devs are naturally blood thirsty people...

$ git log --after=2022-01-01 | grep -w kill | wc -l
207

When people talk about killing stuff they mostly mean deleting code.
Look at this sample of the very first kills from January.  Seven out
of ten times this is what they meant.

$ git log --after=2022-01-01 | grep -w kill | head -n 10
    useless now, kill it.
    net: ipa: kill ipa_table_valid()
    net: ipa: kill two constant symbols
      io_uring: kill hot path fixed file bitmap debug checks
                   newattrs.ia_valid = ATTR_FORCE | kill;
                newattrs.ia_valid = ATTR_FORCE | kill;
                        newattrs.ia_valid = attr_force | kill;
    kill it off before it ends up in a release. It was just part of the
    io_uring: kill hot path fixed file bitmap debug checks
      block: kill deprecated BUG_ON() in the flush handling
$

regards,
dan carpenter