From: "Jason A. Donenfeld" <Jason@zx2c4•com>
To: Steven Rostedt <rostedt@goodmis•org>
Cc: Linus Torvalds <torvalds@linux-foundation•org>,
linux-kernel@vger•kernel.org,
Thomas Gleixner <tglx@linutronix•de>,
Stephen Boyd <sboyd@kernel•org>,
Guenter Roeck <linux@roeck-us•net>,
Anna-Maria Gleixner <anna-maria@linutronix•de>,
Andrew Morton <akpm@linux-foundation•org>,
rcu@vger•kernel.org, linux-doc@vger•kernel.org,
linux-s390@vger•kernel.org, linux-sh@vger•kernel.org,
linux-edac@vger•kernel.org, cgroups@vger•kernel.org,
linux-block@vger•kernel.org, linux-acpi@vger•kernel.org,
linux-atm-general@lists•sourceforge.net, netdev@vger•kernel.org,
linux-pm@vger•kernel.org, drbd-dev@lists•linbit.com,
linux-bluetooth@vger•kernel.org,
openipmi-developer@lists•sourceforge.net,
linux-media@vger•kernel.org, dri-devel@lists•freedesktop.org,
linaro-mm-sig@lists•linaro.org, intel-gfx@lists•freedesktop.org,
linux-input@vger•kernel.org, linux-parisc@vger•kernel.org,
linux-leds@vger•kernel.org, intel-wired-lan@lists•osuosl.org,
linux-usb@vger•kernel.org, linux-wireless@vger•kernel.org,
linux-scsi@vger•kernel.org, linux-staging@lists•linux.dev,
linux-ext4@vger•kernel.org, linux-nilfs@vger•kernel.org,
bridge@lists•linux-foundation.org,
netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
lvs-devel@vger•kernel.org, linux-afs@lists•infradead.org,
linux-nfs@vger•kernel.org, tipc-discussion@lists•sourceforge.net,
alsa-devel@alsa-project•org
Subject: Re: [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers
Date: Sat, 5 Nov 2022 22:03:18 +0100 [thread overview]
Message-ID: <Y2bPlllkHo5DUmLY@zx2c4.com> (raw)
In-Reply-To: <20221105123642.596371c7@rorschach.local.home>
On Sat, Nov 05, 2022 at 12:36:42PM -0400, Steven Rostedt wrote:
> ----------------------8<------------------------
> @@
> identifier ptr, timer, rfield, slab;
> @@
> (
> - del_timer(&ptr->timer);
> + timer_shutdown(&ptr->timer);
> |
> - del_timer_sync(&ptr->timer);
> + timer_shutdown_sync(&ptr->timer);
> )
> ...
> (
> kfree_rcu(ptr, rfield);
> |
> kmem_cache_free(slab, ptr);
> |
> kfree(ptr);
> )
> ---------------------->8------------------------
Something that might help here is changing the `...` into
`... when exists` or into `... when != ptr` or similar.
See this section of the manual:
https://coccinelle.gitlabpages.inria.fr/website/docs/main_grammar004.html
Jason
next prev parent reply other threads:[~2022-11-05 21:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-05 6:00 [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 01/38] SUNRPC/xprt: Use del_timer_sync() instead of del_singleshot_timer_sync() Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 09/38] timers: atm: Use timer_shutdown_sync() before freeing timer Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 14/38] timers: mISDN: " Steven Rostedt
2022-11-05 6:00 ` [PATCH v4a 19/38] timers: nfc: pn533: " Steven Rostedt
2022-11-07 10:13 ` Krzysztof Kozlowski
2022-11-05 6:00 ` [PATCH v4a 34/38] timers: atm: Use timer_shutdown_sync() before a module is released Steven Rostedt
2022-11-05 14:18 ` [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers Guenter Roeck
2022-11-05 14:47 ` Steven Rostedt
2022-11-05 15:59 ` Linus Torvalds
2022-11-05 16:36 ` Steven Rostedt
2022-11-05 16:53 ` Steven Rostedt
2022-11-05 18:03 ` Steven Rostedt
2022-11-05 18:05 ` Steven Rostedt
2022-11-05 18:28 ` Linus Torvalds
2022-11-05 21:03 ` Jason A. Donenfeld [this message]
2022-11-05 21:13 ` Linus Torvalds
2022-11-05 21:45 ` Steven Rostedt
2022-11-05 21:47 ` Steven Rostedt
2022-11-05 17:53 ` Steven Rostedt
2022-11-05 19:31 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2bPlllkHo5DUmLY@zx2c4.com \
--to=jason@zx2c4$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=anna-maria@linutronix$(echo .)de \
--cc=bridge@lists$(echo .)linux-foundation.org \
--cc=cgroups@vger$(echo .)kernel.org \
--cc=coreteam@netfilter$(echo .)org \
--cc=drbd-dev@lists$(echo .)linbit.com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=linaro-mm-sig@lists$(echo .)linaro.org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-afs@lists$(echo .)infradead.org \
--cc=linux-atm-general@lists$(echo .)sourceforge.net \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-bluetooth@vger$(echo .)kernel.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-edac@vger$(echo .)kernel.org \
--cc=linux-ext4@vger$(echo .)kernel.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=linux-nilfs@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=lvs-devel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=openipmi-developer@lists$(echo .)sourceforge.net \
--cc=rcu@vger$(echo .)kernel.org \
--cc=rostedt@goodmis$(echo .)org \
--cc=sboyd@kernel$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=tipc-discussion@lists$(echo .)sourceforge.net \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox